[PATCH] zynqmp: Remove usb init initialization for Kria

Ilias Apalodimas ilias.apalodimas at linaro.org
Wed Dec 18 12:49:09 CET 2024


On Wed, 18 Dec 2024 at 13:41, Michal Simek <michal.simek at amd.com> wrote:
>
> USB hub initialization is done by driver introduced by commit 09f557e106ef
> ("usb: onboard-hub: Add i2c initialization for usb5744 hub") that's why
> there is no need to do initialization via variables.
>
> Reported-by: Love Kumar <love.kumar at amd.com>
> Signed-off-by: Michal Simek <michal.simek at amd.com>
> ---
>
>  board/xilinx/zynqmp/zynqmp_kria.env | 14 ++++----------
>  1 file changed, 4 insertions(+), 10 deletions(-)
>
> diff --git a/board/xilinx/zynqmp/zynqmp_kria.env b/board/xilinx/zynqmp/zynqmp_kria.env
> index ff3a0924de7d..b0c2ac6f2e86 100644
> --- a/board/xilinx/zynqmp/zynqmp_kria.env
> +++ b/board/xilinx/zynqmp/zynqmp_kria.env
> @@ -62,14 +62,8 @@ bootmenu_0=eMMC Boot=run som_mmc_boot
>  bootmenu_1=SD Boot=run som_cc_boot
>  bootmenu_delay=5
>
> -usb_hub_init=mw 1000 0056 && sleep 1 && i2c write 1000 2d aa 2 -s
> -
> -# usb hub init
> -kv260_setup=i2c dev 1 && run usb_hub_init
> -# usb hub init
> -kr260_setup=i2c dev 1 && run usb_hub_init; i2c dev 2 && run usb_hub_init;
> -# usb hub init with enabling PM nodes for ...
> -kd240_setup=i2c dev 1 && run usb_hub_init;zynqmp pmufw node 33; zynqmp pmufw node 47
> +# Enabling PM nodes for uart0 and can0
> +kd240_setup=zynqmp pmufw node 33; zynqmp pmufw node 47
>
>  tpm_setup=tpm autostart;
>  tpm_reset=echo "!!! For TPM reset a full power cycle or pressing the POR_B button is required !!!";
> @@ -79,7 +73,7 @@ tpm_kd240=if test ${card1_rev} = A; then run tpm_reset; fi
>  board_setup=\
>  rtc dev 0; \
>  zynqmp mmio_write 0xFFCA0010 0xfff 0; \
> -if test ${card1_name} = SCK-KV-G; then run kv260_setup; run tpm_kv260; fi;\
> -if test ${card1_name} = SCK-KR-G; then run kr260_setup; run tpm_reset; fi;\
> +if test ${card1_name} = SCK-KV-G; then run tpm_kv260; fi;\
> +if test ${card1_name} = SCK-KR-G; then run tpm_reset; fi;\
>  if test ${card1_name} = SCK-KD-G; then run kd240_setup; run tpm_kd240; fi;\
>  run tpm_setup
> --
> 2.43.0
>

Acked-by: Ilias Apalodimas <ilias.apalodimas at linaro.org>


More information about the U-Boot mailing list