[PATCH v2 5/7] efi_loader: Move the fallback code from efi_run_image()
Simon Glass
sjg at chromium.org
Thu Dec 19 03:43:43 CET 2024
On Thu, 12 Dec 2024 at 15:45, Simon Glass <sjg at chromium.org> wrote:
>
> Hi Ilias,
>
> On Thu, 12 Dec 2024 at 00:53, Ilias Apalodimas
> <ilias.apalodimas at linaro.org> wrote:
> >
> > Checkpatch has errors on this. Please have a look
>
> It's the brackets not matching up because of
> efi_uninstall_multiple_protocol_interfaces() being so long. It also
> complains about possible blank lines at the end of the file, but that
> isn't correct.
>
> >
> > Also for some reason is fails to apply after patch 4.
>
> It is based on top of the other series (confusion between pointers and
> addresses). I can send it independently if you'd like to apply this
> one first.
Yes please, if it's not too much work. I think the other one still
needs bigger adjustments
Thanks
/Ilias
>
> >
> > Thanks
> > /Ilias
> >
> >
> > On Thu, 12 Dec 2024 at 00:38, Simon Glass <sjg at chromium.org> wrote:
> > >
> > > This code is only needed if an invalid image/device path is passed in.
> > > Move the code out to a caller where this can be dealt with. The normal
> > > flow will provide these parameters.
> > >
> > > Signed-off-by: Simon Glass <sjg at chromium.org>
> > > ---
> > >
> > > (no changes since v1)
> > >
> > > lib/efi_loader/efi_bootbin.c | 103 ++++++++++++++++-------------------
> > > 1 file changed, 48 insertions(+), 55 deletions(-)
> > >
Applied to sjg/master, thanks!
More information about the U-Boot
mailing list