[PATCH v2 4/5] arm: dts: k3-am62p5-sk-u-boot: enable USB0 for USB DFU boot

[Roger Quadros]

On 19/12/2024 07:50, Siddharth Vadapalli wrote:
> On Wed, Dec 18, 2024 at 04:05:47PM +0200, Roger Quadros wrote:
> 
> Hello Roger,
> 
>> Hi Siddharth,
>>
>> On 18/12/2024 14:45, Siddharth Vadapalli wrote:
>>> Enable USB0 instance of the USB controller for USB DFU boot functionality
>>> which requires the "bootph-all" property in order to have USB enabled at
>>> all stages of the USB DFU boot.
>>>
>>> Signed-off-by: Siddharth Vadapalli <s-vadapalli at ti.com>
>>> Reviewed-by: Mattijs Korpershoek <mkorpershoek at baylibre.com>
>>> ---
>>> v1:
>>> https://patchwork.ozlabs.org/project/uboot/patch/20241217131658.2920799-5-s-vadapalli@ti.com/
>>> Changes since v1:
>>> - Collected Reviewed-by tag.
>>>
>>>  arch/arm/dts/k3-am62p5-sk-u-boot.dtsi | 10 ++++++++++
>>>  1 file changed, 10 insertions(+)
>>>
>>> diff --git a/arch/arm/dts/k3-am62p5-sk-u-boot.dtsi b/arch/arm/dts/k3-am62p5-sk-u-boot.dtsi
>>> index cf087c6e343..c2091fc1a51 100644
>>> --- a/arch/arm/dts/k3-am62p5-sk-u-boot.dtsi
>>> +++ b/arch/arm/dts/k3-am62p5-sk-u-boot.dtsi
>>> @@ -16,3 +16,13 @@
>>>  &dmsc {
>>>  	bootph-pre-ram;
>>>  };
>>> +
>>> +/* Required for USB DFU boot */
>>> +&usbss0 {
>>> +	status = "okay";
>>> +};
>>
>> This should come via upstream DT sync?
>>
>>> +
>>> +/* Required for USB DFU boot */
>>> +&usb0 {
>>> +	bootph-all;
>>> +};
>>
>> This as well? But I don't see it upstream. Do you have a patch for upstream DT?
> 
> I haven't posted the patch for Linux device-tree yet. I will post it and
> it can be synced with U-Boot later. In order to avoid blocking USB DFU
> support on the Linux device-tree sync, I have posted this patch for this
> series to be complete in terms of functionality. If Linux device-tree
> based sync is the only way to enable this, then the following patch in
> this series for documentation should also be dropped since the feature
> will not be functional without the changes made by this patch.
> 
> Please let me know if this patch can be merged on the condition that I
> post the patch for making the same set of changes in the Linux
> device-tree as well.

Tom, what do you suggest?

-- 
cheers,
-roger