[PATCH v2] common: memtop: Fix the return type for find_ram_top

Sughosh Ganu sughosh.ganu at linaro.org
Fri Dec 20 09:01:53 CET 2024


On Fri, 20 Dec 2024 at 08:38, Venkatesh Yadav Abbarapu
<venkatesh.abbarapu at amd.com> wrote:
>
> As the return type is "int" for find_ram_top() function and
> returning the "base" which is of phys_addr_t is breaking when the
> "base" address is 64-bit. So fix this by updating the return type as
> phys_addr_t.
>
> Signed-off-by: Venkatesh Yadav Abbarapu <venkatesh.abbarapu at amd.com>
> Reviewed-by: Michal Simek <michal.simek at amd.com>
> ---

Acked-by: Sughosh Ganu <sughosh.ganu at linaro.org>

-sughosh

> Changes in v2:
> - Fixed the check patch warning.
> ---
>  common/memtop.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/common/memtop.c b/common/memtop.c
> index 841d89e0799..bff27d8211e 100644
> --- a/common/memtop.c
> +++ b/common/memtop.c
> @@ -121,8 +121,8 @@ static long region_overlap_check(struct mem_region *mem_rgn, phys_addr_t base,
>         return (i < mem_rgn->count) ? i : -1;
>  }
>
> -static int find_ram_top(struct mem_region *free_mem,
> -                       struct mem_region *reserved_mem, phys_size_t size)
> +static phys_addr_t find_ram_top(struct mem_region *free_mem,
> +                               struct mem_region *reserved_mem, phys_size_t size)
>  {
>         long i, rgn;
>         phys_addr_t base = 0;
> --
> 2.34.1
>


More information about the U-Boot mailing list