[PATCH v2 2/8] usb: dwc2: Fix incorrect ULPI_UTMI_SEL bit setting
Marek Vasut
marex at denx.de
Tue Dec 31 19:10:11 CET 2024
On 12/30/24 4:30 AM, Junhui Liu via B4 Relay wrote:
> From: Junhui Liu <liujh2818 at outlook.com>
>
> The ULPI_UTMI_SEL bit in the DWC2 driver was set incorrectly. According
> to the datasheet [1], this bit should be set to 0 for UTMI interface and 1
> for ULPI interface. The existing code had this logic reversed,
> causing the interface selection to be incorrect.
>
> This commit corrects the ULPI_UTMI_SEL bit setting to match the
> datasheet's description. Referencing the kernel's code [2] also confirms
> this fix.
>
> [1] https://rockchip.fr/RK312X%20TRM/chapter-26-usb-otg-2-0.pdf#page=30
> [2] https://github.com/torvalds/linux/blob/v6.13-rc3/drivers/usb/dwc2/core.c#L1106
>
> Signed-off-by: Junhui Liu <liujh2818 at outlook.com>
Reviewed-by: Marek Vasut <marex at denx.de>
More information about the U-Boot
mailing list