[PATCH v2 2/2] bootstd: Replace bootmethod(s) -> bootmeth(s)

Mattijs Korpershoek mkorpershoek at baylibre.com
Wed Jun 5 10:11:28 CEST 2024


Hi Quentin,

Thank you for the review.

On mar., juin 04, 2024 at 17:25, Quentin Schulz <quentin.schulz at cherry.de> wrote:

> Hi Mattijs,
>
> On 6/4/24 5:15 PM, Mattijs Korpershoek wrote:
>> According to [1], we should use bootmeth when describing the
>> struct bootmeth:
>> 
>> """
>> For version 2, a new naming scheme is used as above:
>> 
>>      - bootdev is used instead of bootdevice, because 'device' is overused,
>>          is everywhere in U-Boot, can be confused with udevice
>>      - bootmeth - because 'method' is too vanilla, appears 1300 times in
>>          U-Boot
>> """
>> 
>> Replace all occurences in various comments for consistency.
>> 
>
> s/occurences/occurrences/

Urgh, I guess I spot typos from others but not my own ones :/

>
> Sorry, was too tempting to highlight a typo in a commit that fixes typos :)
>
> (Don't send a v3 for this please :) )

I won't. I hope the person applying this patch can do a fixup.

>
>> [1] https://lore.kernel.org/u-boot/20211023232635.9195-1-sjg@chromium.org/
>
> Reviewed-by: Quentin Schulz <quentin.schulz at cherry.de>
>
> Thanks!
> Quentin


More information about the U-Boot mailing list