[PATCH 0/3] rockchip: rk8xx: fix broken [np]ldo callbacks

Anand Moon linux.amoon at gmail.com
Wed Jun 5 15:11:59 CEST 2024


Hi Quentin,

On Wed, 5 Jun 2024 at 15:03, Quentin Schulz <foss+uboot at 0leil.net> wrote:
>
> This is for master branch, merge ASAP as it's known to break at least
> Chromebook Jerry.
>
> @Simon, can you please check that this fixes your CB?
>
> The wrong udevice was passed to the functions, making them call the
> pmic callbacks on the parent of the pmic udevice instead of the pmic
> udevice itself.
>
> While at it, ensure consistency by having all internal functions use
> pmic udevice instead of the regulator udevice.
>
> Finally, clarify operator precedence in ternary condition as reported by
> my linter.
>
> Signed-off-by: Quentin Schulz <quentin.schulz at cherry.de>

I see we have not been able to follow configs on a few of the board's for RK3588

CONFIG_CMD_REGULATOR=y
CONFIG_PMIC_RK8XX=y
CONFIG_REGULATOR_RK8XX=y

could you enable the options with imply for all the rockchip boards?

Thanks
-Anand

> ---
> Quentin Schulz (3):
>       regulator: rk8xx: fix incorrect device used for _ldo_[sg]et_suspend_value
>       regulator: rk8xx: pass pmic udevice instead of regulator to all internal functions
>       regulator: rk8xx: clarify operator precedence
>
>  drivers/power/regulator/rk8xx.c | 54 ++++++++++++++++++++---------------------
>  1 file changed, 27 insertions(+), 27 deletions(-)
> ---
> base-commit: c0ea27bccfb7d2d37fd36806ac2a2f7389099420
> change-id: 20240605-pmic-rk8xx-52f2286be334
>
> Best regards,
> --
> Quentin Schulz <quentin.schulz at cherry.de>
>


More information about the U-Boot mailing list