[RFC PATCH 01/31] lmb: remove the unused lmb_is_reserved() function

Ilias Apalodimas ilias.apalodimas at linaro.org
Mon Jun 10 11:33:59 CEST 2024


On Fri, 7 Jun 2024 at 21:53, Sughosh Ganu <sughosh.ganu at linaro.org> wrote:
>
> The lmb_is_reserved() API is not used. There is another API,
> lmb_is_reserved_flags() which can be used to check if a particular
> memory region is reserved. Remove the unused API.
>
> Signed-off-by: Sughosh Ganu <sughosh.ganu at linaro.org>
> ---
>  include/lmb.h | 11 -----------
>  lib/lmb.c     |  5 -----
>  2 files changed, 16 deletions(-)
>
> diff --git a/include/lmb.h b/include/lmb.h
> index 231b68b27d..6c50d93e83 100644
> --- a/include/lmb.h
> +++ b/include/lmb.h
> @@ -117,17 +117,6 @@ phys_addr_t __lmb_alloc_base(struct lmb *lmb, phys_size_t size, ulong align,
>  phys_addr_t lmb_alloc_addr(struct lmb *lmb, phys_addr_t base, phys_size_t size);
>  phys_size_t lmb_get_free_size(struct lmb *lmb, phys_addr_t addr);
>
> -/**
> - * lmb_is_reserved() - test if address is in reserved region
> - *
> - * The function checks if a reserved region comprising @addr exists.
> - *
> - * @lmb:       the logical memory block struct
> - * @addr:      address to be tested
> - * Return:     1 if reservation exists, 0 otherwise
> - */
> -int lmb_is_reserved(struct lmb *lmb, phys_addr_t addr);
> -
>  /**
>   * lmb_is_reserved_flags() - test if address is in reserved region with flag bits set
>   *
> diff --git a/lib/lmb.c b/lib/lmb.c
> index 44f9820531..adc3abd5b4 100644
> --- a/lib/lmb.c
> +++ b/lib/lmb.c
> @@ -565,11 +565,6 @@ int lmb_is_reserved_flags(struct lmb *lmb, phys_addr_t addr, int flags)
>         return 0;
>  }
>
> -int lmb_is_reserved(struct lmb *lmb, phys_addr_t addr)
> -{
> -       return lmb_is_reserved_flags(lmb, addr, LMB_NONE);
> -}
> -
>  __weak void board_lmb_reserve(struct lmb *lmb)
>  {
>         /* please define platform specific board_lmb_reserve() */
> --
> 2.34.1
>

Reviewed-by: Ilias Apalodimas <ilias.apalodimas at linaro.org>


More information about the U-Boot mailing list