[PATCH 0/4] boot: fix crash in bootflow menu with EFI BOOTMGR support + typos

Quentin Schulz foss+uboot at 0leil.net
Wed Jun 12 16:58:45 CEST 2024


bootflow menu currently crashes U-Boot with a NULL pointer dereference
because bootflow->dev is NULL for global bootmeths (such as EFI BOOTMGR).
Therefore, let's check if the bootflow is associated with a global
bootmeth before trying to make it part of the menu.

While this makes U-Boot not crash anymore, bootflow menu doesn't work
for me (I have never had a happy path with it, but I haven't actually
tried it before today :) ) and this was basically just implemented
following Simon's suggestion sent over IRC. No clue if this is enough or
just a quick band-aid patch.

This also fixes typos in multiple places.

Signed-off-by: Quentin Schulz <quentin.schulz at cherry.de>
---
Quentin Schulz (4):
      cmd: fix typo in CMD_BOOTMETH help text
      boot: fix typos in help text of Kconfig configs
      doc: bootstd: fix typos
      boot: bootflow_menu: fix crash for EFI BOOTMGR global bootmeth

 boot/Kconfig            | 22 +++++++++++-----------
 boot/bootflow_menu.c    |  7 +++++++
 cmd/Kconfig             |  2 +-
 doc/develop/bootstd.rst | 50 ++++++++++++++++++++++++-------------------------
 include/bootflow.h      |  3 ++-
 5 files changed, 46 insertions(+), 38 deletions(-)
---
base-commit: 1ebd659cf020843fd8e8ef90d85a66941cbab6ec
change-id: 20240612-bootflow-efi-crash-c52449ef643e

Best regards,
-- 
Quentin Schulz <quentin.schulz at cherry.de>



More information about the U-Boot mailing list