[PATCH v4 0/3] cyclic/watchdog patches

Stefan Roese sr at denx.de
Sun Jun 16 12:18:24 CEST 2024


On 5/21/24 10:46, Rasmus Villemoes wrote:
> A bit of a mixed bag. I've been wanting to submit something like 3/3
> for a while. So when I stumbled on Marek's patch
> https://lore.kernel.org/u-boot/20240316201416.211480-1-marek.vasut+renesas@mailbox.org/
> , I got reminded of that plan, and I think that patch could be more
> readable if we adopt this model.
> 
> While actually doing those mostly mechanical changes, I stumbled on
> two separate issues that probably want fixing regardless of the fate
> of 3/3.
> 
> Mostly just compile-tested, and now also checked that at least the
> sandbox test runs succesfully, and that it builds both with and
> without CONFIG_CYCLIC.
> 
> v4: Make sure there's only one definition of struct cyclic_info, previous
> versions failed to move the full definition under #ifdef CONFIG_CYCLIC,
> breaking builds with !CONFIG_CYCLIC.
> 
> v3: Also update the unit test according to the new API.
> 
> v2: Add R-bs from Stefan. Fixup whitespace in the doc/ part. Rebase
> to current master (676903c1b97), fixing trivial conflict with
> 301bac6047c8.
> 
> Rasmus Villemoes (3):
>    cyclic: stop strdup'ing name in cyclic_register()
>    wdt-uclass: prevent multiple cyclic_register calls
>    cyclic: make clients embed a struct cyclic_info in their own data
>      structure

Applied to u-boot-watchdog/next

Thanks,
Stefan

>   board/Marvell/octeon_nic23/board.c |  9 ++++---
>   cmd/cyclic.c                       | 12 ++++------
>   common/cyclic.c                    | 24 +++++--------------
>   doc/develop/cyclic.rst             | 26 ++++++++++++--------
>   drivers/watchdog/wdt-uclass.c      | 38 ++++++++++++++++--------------
>   include/cyclic.h                   | 37 +++++++++++++++--------------
>   test/common/cyclic.c               | 19 +++++++++------
>   7 files changed, 84 insertions(+), 81 deletions(-)
> 

Viele Grüße,
Stefan Roese

-- 
DENX Software Engineering GmbH,      Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr at denx.de


More information about the U-Boot mailing list