[PATCH 1/3] rockchip: rock-3a: rock5a: rock5b: add USB GADGET related configs

[FUKAUMI Naoki]

Hi,

On 6/16/24 18:24, Jonas Karlman wrote:
> On 2024-06-15 09:46, FUKAUMI Naoki wrote:
>> add USB GADGET related configs for USB OTG port on ROCK 3A/5A/5B.
>>
>> Signed-off-by: FUKAUMI Naoki <naoki at radxa.com>
>> ---
>>   configs/rock-3a-rk3568_defconfig | 6 ++++++
>>   configs/rock5a-rk3588s_defconfig | 6 ++++++
>>   configs/rock5b-rk3588_defconfig  | 1 +
>>   3 files changed, 13 insertions(+)
>>
>> diff --git a/configs/rock-3a-rk3568_defconfig b/configs/rock-3a-rk3568_defconfig
>> index 66ac2f6d7a..0568a73038 100644
>> --- a/configs/rock-3a-rk3568_defconfig
>> +++ b/configs/rock-3a-rk3568_defconfig
>> @@ -37,6 +37,8 @@ CONFIG_CMD_MMC=y
>>   CONFIG_CMD_PCI=y
>>   CONFIG_CMD_POWEROFF=y
>>   CONFIG_CMD_USB=y
>> +CONFIG_CMD_ROCKUSB=y
>> +CONFIG_CMD_USB_MASS_STORAGE=y
>>   # CONFIG_CMD_SETEXPR is not set
>>   CONFIG_CMD_PMIC=y
>>   CONFIG_CMD_REGULATOR=y
>> @@ -50,6 +52,7 @@ CONFIG_SPL_SYSCON=y
>>   CONFIG_SCSI_AHCI=y
>>   CONFIG_AHCI_PCI=y
>>   CONFIG_SPL_CLK=y
>> +# CONFIG_USB_FUNCTION_FASTBOOT is not set
>>   CONFIG_ROCKCHIP_GPIO=y
>>   CONFIG_SYS_I2C_ROCKCHIP=y
>>   CONFIG_MISC=y
>> @@ -90,4 +93,7 @@ CONFIG_USB_OHCI_HCD=y
>>   CONFIG_USB_OHCI_GENERIC=y
>>   CONFIG_USB_DWC3=y
>>   CONFIG_USB_DWC3_GENERIC=y
>> +CONFIG_USB_GADGET=y
>> +CONFIG_USB_GADGET_DOWNLOAD=y
>> +CONFIG_USB_FUNCTION_ROCKUSB=y
>>   CONFIG_ERRNO_STR=y
>> diff --git a/configs/rock5a-rk3588s_defconfig b/configs/rock5a-rk3588s_defconfig
>> index c09e6655f0..e06052cd80 100644
>> --- a/configs/rock5a-rk3588s_defconfig
>> +++ b/configs/rock5a-rk3588s_defconfig
>> @@ -27,6 +27,8 @@ CONFIG_CMD_GPT=y
>>   CONFIG_CMD_I2C=y
>>   CONFIG_CMD_MMC=y
>>   CONFIG_CMD_USB=y
>> +CONFIG_CMD_ROCKUSB=y
>> +CONFIG_CMD_USB_MASS_STORAGE=y
>>   # CONFIG_CMD_SETEXPR is not set
>>   CONFIG_CMD_REGULATOR=y
>>   # CONFIG_SPL_DOS_PARTITION is not set
>> @@ -37,6 +39,7 @@ CONFIG_SPL_DM_SEQ_ALIAS=y
>>   CONFIG_SPL_REGMAP=y
>>   CONFIG_SPL_SYSCON=y
>>   CONFIG_SPL_CLK=y
>> +# CONFIG_USB_FUNCTION_FASTBOOT is not set
>>   CONFIG_ROCKCHIP_GPIO=y
>>   CONFIG_SYS_I2C_ROCKCHIP=y
>>   CONFIG_MISC=y
>> @@ -67,4 +70,7 @@ CONFIG_USB_OHCI_HCD=y
>>   CONFIG_USB_OHCI_GENERIC=y
>>   CONFIG_USB_DWC3=y
>>   CONFIG_USB_DWC3_GENERIC=y
>> +CONFIG_USB_GADGET=y
>> +CONFIG_USB_GADGET_DOWNLOAD=y
>> +CONFIG_USB_FUNCTION_ROCKUSB=y
> 
> I do not think there is any usb port that use dr_mode otg/peripheral,
> so enabling gadget support probably have no impact on ROCK 5A.
> 
> Regards,
> Jonas

my patch 2/3 doesn't add "dr_mode = "host";", so it will be "otg".
I may need to fix upstream dts first...

--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.

> 
>>   CONFIG_ERRNO_STR=y
>> diff --git a/configs/rock5b-rk3588_defconfig b/configs/rock5b-rk3588_defconfig
>> index fc118cea7b..80a2f2fed5 100644
>> --- a/configs/rock5b-rk3588_defconfig
>> +++ b/configs/rock5b-rk3588_defconfig
>> @@ -39,6 +39,7 @@ CONFIG_CMD_MMC=y
>>   CONFIG_CMD_PCI=y
>>   CONFIG_CMD_USB=y
>>   CONFIG_CMD_ROCKUSB=y
>> +CONFIG_CMD_USB_MASS_STORAGE=y
>>   # CONFIG_CMD_SETEXPR is not set
>>   CONFIG_CMD_REGULATOR=y
>>   # CONFIG_SPL_DOS_PARTITION is not set
> 
>