[PATCH 1/1] usb: informative message if no controller

Dragan Simic dsimic at manjaro.org
Mon Jun 17 10:20:56 CEST 2024


Hello Heinrich,

On 2024-06-17 10:16, Heinrich Schuchardt wrote:
> The message 'No working controllers found' provides no clue that this
> refers to USB controllers.
> 
> Provide a message that refers to USB. Use log_info().
> 
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt at canonical.com>
> ---
>  drivers/usb/host/usb-uclass.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/host/usb-uclass.c 
> b/drivers/usb/host/usb-uclass.c
> index a1cd0ad2d66..e16432a1516 100644
> --- a/drivers/usb/host/usb-uclass.c
> +++ b/drivers/usb/host/usb-uclass.c
> @@ -388,7 +388,7 @@ int usb_init(void)
> 
>  	/* if we were not able to find at least one working bus, bail out */
>  	if (controllers_initialized == 0)
> -		printf("No working controllers found\n");
> +		log_info("No USB controller\n");

It would be better to use "No USB controllers found" as the error 
message,
because it reads better and provides additional clues.

>  	return usb_started ? 0 : -ENOENT;
>  }


More information about the U-Boot mailing list