[PATCH v2 2/2] bootstd: Replace bootmethod(s) -> bootmeth(s)
Simon Glass
sjg at chromium.org
Mon Jun 17 15:53:25 CEST 2024
Hi,
On Sun, 16 Jun 2024 at 01:43, Heinrich Schuchardt <xypron.glpk at gmx.de> wrote:
>
> On 6/4/24 17:15, Mattijs Korpershoek wrote:
> > According to [1], we should use bootmeth when describing the
> > struct bootmeth:
> >
> > """
> > For version 2, a new naming scheme is used as above:
> >
> > - bootdev is used instead of bootdevice, because 'device' is overused,
> > is everywhere in U-Boot, can be confused with udevice
>
> Boot devices are udevices though they don't relate to hardware but to an
> abstract concept.
>
> bootdev is just an abbreviation. This does not make the meaning any clearer.
>
> > - bootmeth - because 'method' is too vanilla, appears 1300 times in
> > U-Boot
> > """
>
> Avoiding abbreviations like bootdev and bootmeth improved readability.
I think people need to learn the terms used in the code. Having a term
used consistently seems like a win to me. The documentation helps here
too, e.g. [1]
Reviewed-by: Simon Glass <sjg at chromium.org>
Regards,
Simon
[1] https://docs.u-boot.org/en/latest/develop/bootstd.html#bootmeth
More information about the U-Boot
mailing list