[PATCH 08/11] usb: gadget: musb: Convert interrupt handling to usb_gadget_generic_ops
Mattijs Korpershoek
mkorpershoek at baylibre.com
Tue Jun 18 09:36:42 CEST 2024
Hi Marek,
Thank you for the patch.
On ven., juin 14, 2024 at 02:51, Marek Vasut <marek.vasut+renesas at mailbox.org> wrote:
> Implement .handle_interrupts callback as a replacement for deprecated
> dm_usb_gadget_handle_interrupts() function. The new callback allows
> for each DM capable USB gadget controller driver to define its own
> IRQ handling implementation without colliding with other controller
> drivers.
>
> Signed-off-by: Marek Vasut <marek.vasut+renesas at mailbox.org>
Reviewed-by: Mattijs Korpershoek <mkorpershoek at baylibre.com>
> ---
> Cc: Alexander Sverdlin <alexander.sverdlin at siemens.com>
> Cc: Felipe Balbi <felipe.balbi at linux.intel.com>
> Cc: Lukasz Majewski <lukma at denx.de>
> Cc: Mattijs Korpershoek <mkorpershoek at baylibre.com>
> Cc: Nishanth Menon <nm at ti.com>
> Cc: Simon Glass <sjg at chromium.org>
> Cc: Thinh Nguyen <Thinh.Nguyen at synopsys.com>
> Cc: Tom Rini <trini at konsulko.com>
> Cc: u-boot at lists.denx.de
> ---
> drivers/usb/musb-new/ti-musb.c | 23 ++++++++++++++---------
> 1 file changed, 14 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/usb/musb-new/ti-musb.c b/drivers/usb/musb-new/ti-musb.c
> index 76e8b88369e..ec1baa9337d 100644
> --- a/drivers/usb/musb-new/ti-musb.c
> +++ b/drivers/usb/musb-new/ti-musb.c
> @@ -233,15 +233,6 @@ static int ti_musb_peripheral_of_to_plat(struct udevice *dev)
> }
> #endif
>
> -int dm_usb_gadget_handle_interrupts(struct udevice *dev)
> -{
> - struct ti_musb_peripheral *priv = dev_get_priv(dev);
> -
> - priv->periph->isr(0, priv->periph);
> -
> - return 0;
> -}
> -
> static int ti_musb_peripheral_probe(struct udevice *dev)
> {
> struct ti_musb_peripheral *priv = dev_get_priv(dev);
> @@ -269,12 +260,26 @@ static int ti_musb_peripheral_remove(struct udevice *dev)
> return 0;
> }
>
> +static int ti_musb_gadget_handle_interrupts(struct udevice *dev)
> +{
> + struct ti_musb_peripheral *priv = dev_get_priv(dev);
> +
> + priv->periph->isr(0, priv->periph);
> +
> + return 0;
> +}
> +
> +static const struct usb_gadget_generic_ops ti_musb_gadget_ops = {
> + .handle_interrupts = ti_musb_gadget_handle_interrupts,
> +};
> +
> U_BOOT_DRIVER(ti_musb_peripheral) = {
> .name = "ti-musb-peripheral",
> .id = UCLASS_USB_GADGET_GENERIC,
> #if CONFIG_IS_ENABLED(OF_CONTROL)
> .of_to_plat = ti_musb_peripheral_of_to_plat,
> #endif
> + .ops = &ti_musb_gadget_ops,
> .probe = ti_musb_peripheral_probe,
> .remove = ti_musb_peripheral_remove,
> .ops = &musb_usb_ops,
> --
> 2.43.0
More information about the U-Boot
mailing list