[PATCH v3 1/1] usb: informative message if no controller

Caleb Connolly caleb.connolly at linaro.org
Tue Jun 18 12:34:11 CEST 2024



On 18/06/2024 11:58, Heinrich Schuchardt wrote:
> The message 'No working controllers found' provides no clue that this
> refers to USB controllers.
> 
> Provide a message that refers to USB. Use log_info().
> 
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt at canonical.com>
Reviewed-by: Caleb Connolly <caleb.connolly at linaro.org>
> ---
> v3:
> 	plural controllers
> v2:
> 	add 'found' at end of message
> 	keep printf
> ---
>   drivers/usb/host/usb-uclass.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/host/usb-uclass.c b/drivers/usb/host/usb-uclass.c
> index a1cd0ad2d66..e16432a1516 100644
> --- a/drivers/usb/host/usb-uclass.c
> +++ b/drivers/usb/host/usb-uclass.c
> @@ -388,7 +388,7 @@ int usb_init(void)
>   
>   	/* if we were not able to find at least one working bus, bail out */
>   	if (controllers_initialized == 0)
> -		printf("No working controllers found\n");
> +		printf("No USB controllers found\n");
>   
>   	return usb_started ? 0 : -ENOENT;
>   }

-- 
// Caleb (they/them)


More information about the U-Boot mailing list