[PATCH 1/1] spl: correct link to FIT specification

Heinrich Schuchardt heinrich.schuchardt at canonical.com
Tue Jun 18 14:33:57 CEST 2024


On 18.06.24 13:54, Marek Vasut wrote:
> On 6/18/24 8:32 AM, Heinrich Schuchardt wrote:
>> Replace the invalid link to the FIT file format specification.
>>
>> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt at canonical.com>
>> ---
>> SPL is tightly size constrained.
>>
>> Shouldn't we remove the message with the link which is only of interest
>> to developers.
>> ---
>>   common/spl/spl_fit.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/common/spl/spl_fit.c b/common/spl/spl_fit.c
>> index 988125be008..2a097f4464c 100644
>> --- a/common/spl/spl_fit.c
>> +++ b/common/spl/spl_fit.c
>> @@ -587,7 +587,7 @@ __weak void *spl_load_simple_fit_fix_load(const 
>> void *fit)
>>   static void warn_deprecated(const char *msg)
>>   {
>>       printf("DEPRECATED: %s\n", msg);
>> -    printf("\tSee doc/uImage.FIT/source_file_format.txt\n");
>> +    printf("\tSee https://fitspec.osfw.foundation/\n");
> 
> Why not fix the link to local documentation in the source tree instead ?
> 
> I would much prefer that than random links to random websites .

The internal page is going away, cf.

[RFC 1/1] doc: Remove FIT documentation that is elsewhere
https://lore.kernel.org/u-boot/20240617202041.3740154-2-sam.povilus@amd.com/

Best regards

Heinrich


More information about the U-Boot mailing list