[PATCH v4 1/4] binman: Add nxp_imx8mcst etype for i.MX8M flash.bin signing

[Simon Glass]

Hi again,

On Tue, 11 Jun 2024 at 12:51, Simon Glass <sjg at chromium.org> wrote:
>
> Hi,
>
> On Fri, 24 May 2024 at 10:26, Fabio Estevam <festevam at gmail.com> wrote:
> >
> > On Tue, May 21, 2024 at 7:48 AM Marek Vasut <marex at denx.de> wrote:
> > >
> > > Add new binman etype which allows signing both the SPL and fitImage sections
> > > of i.MX8M flash.bin using CST. There are multiple DT properties which govern
> > > the signing process, nxp,loader-address is the only mandatory one which sets
> > > the SPL signature start address without the imx8mimage header, this should be
> > > SPL text base. The key material can be configured using optional DT properties
> > > nxp,srk-table, nxp,csf-crt, nxp,img-crt, all of which default the key material
> > > names generated by CST tool scripts. The nxp,unlock property can be used to
> > > unlock CAAM access in SPL section.
> > >
> > > Reviewed-by: Tim Harvey <tharvey at gateworks.com>
> > > Signed-off-by: Marek Vasut <marex at denx.de>
> >
> > Applied the series, thanks.
>
> This lacks tests - can you please add sufficient tests in ftest.py to
> get the cover coverage back to 100%? Please try 'binman test -T' to
> see this.

Any thoughts on this, please? At present -master is broken for one
file and -next has three problems.

master:
tools/binman/etype/nxp_imx8mimage.py                       38     26    32%

next:
tools/binman/btool/cst.py                                  15      4    73%
tools/binman/etype/nxp_imx8mcst.py                         78     59    24%
tools/binman/etype/nxp_imx8mimage.py                       38     26    32%

All the others are 100%.

This is clearly covered in the Binman documentation[1].

I will see if I can add this to CI.

Regards,
Simon

[1] https://docs.u-boot.org/en/latest/develop/package/binman.html#code-coverage