[PATCH 12/20] cyclic: Rise default CYCLIC_MAX_CPU_TIME_US to 5000

Stefan Roese sr at denx.de
Tue Jun 18 16:01:03 CEST 2024


On 6/18/24 01:29, Tom Rini wrote:
> On Fri, Jun 14, 2024 at 04:13:54PM +0200, Stefan Roese wrote:
>> On 6/12/24 18:50, Tom Rini wrote:
>>> On Wed, Jun 12, 2024 at 05:13:37PM +0100, Jiaxun Yang wrote:
>>>>
>>>>
>>>> 在2024年6月12日六月 下午5:00,Tom Rini写道:
>>>> [...]
>>>>>>    configs/octeon_nic23_defconfig | 1 -
>>>>>>    2 files changed, 1 insertion(+), 2 deletions(-)
>>>>>
>>>>> This seems similar to:
>>>>> https://patchwork.ozlabs.org/project/uboot/patch/20240524210817.1953298-1-rasmus.villemoes@prevas.dk/
>>>>>
>>>>> at least for CI. And for outside CI, I'm OK with just having the value
>>>>> be changed in the defconfig as needed. We do support using config
>>>>> fragments, so keeping such changes locally isn't too hard.
>>>>
>>>> So the default value is a little bit too hard even for some of the actual
>>>> hardware.
>>>
>>> Right, there's some platforms where it's too small and we should just
>>> bump it up. I think for now the default is what we want it to be for
>>> most platforms.
>>
>> The current default value is definitely too small, especially when CI
>> is involved (I did not have this in mind when implementing), so:
>>
>> Acked-by: Stefan Roese <sr at denx.de>
> 
> Can we please get either this, or
> https://patchwork.ozlabs.org/project/uboot/patch/20240524210817.1953298-1-rasmus.villemoes@prevas.dk/
> merged for master? The number of false negatives in CI due to this is
> big issue for getting more contributors to use CI. Thanks.

Yes.

Applied to u-boot-watchdog/master

Thanks,
Stefan


More information about the U-Boot mailing list