[PATCH] rockchip: include cru_rk3588.h and define rockchip_cru for RK3588

FUKAUMI Naoki naoki at radxa.com
Tue Jun 18 22:29:18 CEST 2024


Hello,

this happens only if HOSTCC=clang. I can see several other errors on 
several other targets with HOSTCC=clang.

CC=clang seems to be fine.

Best regards,

--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.

On 6/19/24 04:30, FUKAUMI Naoki wrote:
> fix following error found by clang:
> 
>    CC      arch/arm/mach-rockchip/cpu-info.o
> arch/arm/mach-rockchip/cpu-info.c:23:13: error: incomplete definition of type 'struct rockchip_cru'
>     23 |         switch (cru->glb_rst_st) {
>        |                 ~~~^
> ./arch/arm/include/asm/arch-rockchip/clock.h:181:8: note: forward declaration of 'struct rockchip_cru'
>    181 | struct rockchip_cru;
>        |        ^
> 1 error generated.
> 
> Signed-off-by: FUKAUMI Naoki <naoki at radxa.com>
> ---
>   arch/arm/include/asm/arch-rockchip/cru.h        | 2 ++
>   arch/arm/include/asm/arch-rockchip/cru_rk3588.h | 2 ++
>   2 files changed, 4 insertions(+)
> 
> diff --git a/arch/arm/include/asm/arch-rockchip/cru.h b/arch/arm/include/asm/arch-rockchip/cru.h
> index 9778790f34..c3259b8e7c 100644
> --- a/arch/arm/include/asm/arch-rockchip/cru.h
> +++ b/arch/arm/include/asm/arch-rockchip/cru.h
> @@ -17,6 +17,8 @@
>   # include <asm/arch-rockchip/cru_rk3399.h>
>   #elif defined(CONFIG_ROCKCHIP_RK3568)
>   #include <asm/arch-rockchip/cru_rk3568.h>
> +#elif defined(CONFIG_ROCKCHIP_RK3588)
> +#include <asm/arch-rockchip/cru_rk3588.h>
>   #endif
>   
>   /* CRU_GLB_RST_ST */
> diff --git a/arch/arm/include/asm/arch-rockchip/cru_rk3588.h b/arch/arm/include/asm/arch-rockchip/cru_rk3588.h
> index a0e54d3965..dad484813f 100644
> --- a/arch/arm/include/asm/arch-rockchip/cru_rk3588.h
> +++ b/arch/arm/include/asm/arch-rockchip/cru_rk3588.h
> @@ -92,6 +92,8 @@ struct rk3588_cru {
>   	unsigned int pmuclkgate_con[9]; /* Address Offset: 0x0100 */
>   };
>   
> +#define rockchip_cru rk3588_cru
> +
>   check_member(rk3588_cru, mode_con00, 0x280);
>   check_member(rk3588_cru, pmuclksel_con[1], 0x30304);
>   


More information about the U-Boot mailing list