[PATCH] board: beagle: beagleplay: enable OF_SYSTEM_SETUP

Chirag Shilwant c-shilwant at ti.com
Thu Jun 20 08:25:10 CEST 2024


On 20/06/24 11:21, Dhruva Gole wrote:
> On Jun 19, 2024 at 15:44:41 -0500, Andrew Davis wrote:
>> On 6/19/24 2:12 PM, Bryan Brattlof wrote:
>>> Unfortunately when enabling FDT fixups for the AM62x family of SoCs and
>>> moving TF-A to the bottom of RAM we missed the BeaglePlay. This is
>>> causing Linux's memory allocator to clobber TF-A and break its boot.
>>>
>>> Enable OF_SYSTEM_SETUP to fixup the kernel's FDT to inform it of the
>>> actual location of the firmware
>>>
>>> CC: Andrew Davis <afd at ti.com>
>>> CC: Nishanth Menon <nm at ti.com>
>>> CC: Robert Nelson <robertcnelson at gmail.com>
>>> Reported-by: Dhruva Gole <d-gole at ti.com>
>>> Signed-off-by: Bryan Brattlof <bb at ti.com>
>>> ---
>> Acked-by: Andrew Davis <afd at ti.com>


Acked-by: Chirag Shilwant <c-shilwant at ti.com>



>>> Hello everyone,
>>>
>>> Fair warning, this may turn into a philosophical discussion about the
>>> role of device-tree with SystemReady and U-Boot's role in enabling true
>>> distribution to be completely agnostic of the board it's running on.
>>>
>>> However substantively this is simply fixing a boot regression Dhruva
>>> found while testing out the beagleplay.
>>>
>>> Happy reviewing
>>> ~Bryan
>>> ---
>>>    board/beagle/beagleplay/Kconfig | 1 +
>>>    1 file changed, 1 insertion(+)
>>>
>>> diff --git a/board/beagle/beagleplay/Kconfig b/board/beagle/beagleplay/Kconfig
>>> index 7dbd833acb4cc..896a1c1be3010 100644
>>> --- a/board/beagle/beagleplay/Kconfig
>>> +++ b/board/beagle/beagleplay/Kconfig
>>> @@ -12,6 +12,7 @@ config TARGET_AM625_A53_BEAGLEPLAY
>>>    	bool "BeagleBoard.org AM625 BeaglePlay running on A53"
>>>    	select ARM64
>>>    	select BINMAN
>>> +	select OF_SYSTEM_SETUP
> Thanks for the quick fix,
> Tested-by: Dhruva Gole <d-gole at ti.com>
>
> Boot logs upto kernel prompt:
> https://gist.github.com/DhruvaG2000/4dc1c1e42207dd98a144f27cc9dff177
>


More information about the U-Boot mailing list