[PATCH 3/5] phy: meson-gxl-usb2: remove phy_meson_gxl_usb2_set_mode

Neil Armstrong neil.armstrong at linaro.org
Thu Jun 20 09:39:48 CEST 2024


On 18/06/2024 16:56, Marek Vasut wrote:
> On 6/18/24 9:55 AM, Neil Armstrong wrote:
> 
> [...]
> 
>> @@ -205,7 +188,7 @@ static int phy_meson_gxl_usb2_power_off(struct phy *phy)
>>   struct phy_ops meson_gxl_usb2_phy_ops = {
>>       .power_on = phy_meson_gxl_usb2_power_on,
>>       .power_off = phy_meson_gxl_usb2_power_off,
>> -    .set_mode = _phy_meson_gxl_usb2_set_mode,
>> +    .set_mode = phy_meson_gxl_usb2_set_mode,
> 
> Oh, I see you did rename it here, so please ignore my comment on 1/5 . Maybe just mention in the 1/5 commit message that the rename is happening in follow up patch , if you are doing V2 at all .

Sure, let me update the commit message,

Thanks,
Neil




More information about the U-Boot mailing list