[PATCH] dt-bindings: imx: Drop redundant imports with dts/upstream

[Michael Nazzareno Trimarchi]

Hi Sumit

On Thu, Jun 20, 2024 at 6:55 AM Sumit Garg <sumit.garg at linaro.org> wrote:
>
> On Wed, 19 Jun 2024 at 18:51, Michael Nazzareno Trimarchi
> <michael at amarulasolutions.com> wrote:
> >
> > Hi
> >
> > On Wed, Jun 19, 2024 at 3:07 PM Sumit Garg <sumit.garg at linaro.org> wrote:
> > >
> > > On Wed, 19 Jun 2024 at 18:26, Adam Ford <aford173 at gmail.com> wrote:
> > > >
> > > > On Wed, Jun 19, 2024 at 7:53 AM Sumit Garg <sumit.garg at linaro.org> wrote:
> > > > >
> > > > > Drop redundant header imports with dts/upstream already providing
> > > > > updated headers which have been checked to be backwards compatibility.
> > > > >
> > > > > The imx headers which aren't present in dts/upstream are as follows:
> > > > >
> > > > > - include/dt-bindings/clock/imxrt1020-clock.h
> > > > > - include/dt-bindings/clock/imx8qm-clock.h
> > > > > - include/dt-bindings/clock/imxrt1170-clock.h
> > > > > - include/dt-bindings/clock/imx8qxp-clock.h
> > > > > - include/dt-bindings/memory/imxrt-sdram.h
> > > > > - include/dt-bindings/pinctrl/pads-imx8qxp.h
> > > > > - include/dt-bindings/pinctrl/pads-imx8qm.h
> > > > > - include/dt-bindings/soc/imx8_pd.h
> > > > > - include/dt-bindings/soc/imx_rsrc.h
> > > > >
> > > > > hence these aren't dropped yet but there was an unused header:
> > > > >
> > > > > - include/dt-bindings/pinctrl/pins-imx8mq.h
> > > > >
> > > > > which has been dropped as well. There shouldn't be any funtional impact
> > > > > with this change but it rather allows iMX platforms to use upstream
> > > > > dt-bindings headers in a backwards compatible manner.
> > > >
> > > > Will this have any impact on board with -u-boot.dtsi files that might
> > > > reference these files or will they point to the upstream path?
> > > >
> > >
> > > No it won't have any impact on existing boards, the headers would
> > > rather just be included from dts/upstream/include/dt-bindings/
> > > instead. The DT files would just be including headers the same way as
> > > before: #include <dt-bindings/foo/bar.h>. The world build is ongoing
> > > here [1] which should be able to justify it.
> > >
> > > [1] https://github.com/u-boot/u-boot/pull/587
> > >
> >
> > They will point to the upstream part but the fact it's that you can
> > test only that they compile ;).
>
> Majority of the headers removed have been compared to be identical and
> the rest headers have been checked to be DT ABI compatible with
> upstream counterparts. IMHO, that should be enough to believe the
> correctness of this patch. If you would like to manually review them
> or give this patch a try on a real iMX device then please feel free to
> do that.
>
> -Sumit

I would like to move this on. I prefer two step approach and fix
broken things and then maybe drop
legacy

Reviewed-by: Michael Trimarchi <michael at amarulasolutions.com>



-- 
Michael Nazzareno Trimarchi
Co-Founder & Chief Executive Officer
M. +39 347 913 2170
michael at amarulasolutions.com
__________________________________

Amarula Solutions BV
Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
T. +31 (0)85 111 9172
info at amarulasolutions.com
www.amarulasolutions.com