[PATCH v2] arm: dts: k3-am625-beagleplay: Package TIFS Stub

[Dhruva Gole]

Bryan,

On Jun 19, 2024 at 16:44:48 -0500, Bryan Brattlof wrote:
> On June 18, 2024 thus sayeth Dhruva Gole:
> > Add support for packaging the TIFS Stub as it's required for basic Low
> > Power Modes like Deep Sleep.
> > 
> > Acked-by: Neha Malcom Francis <n-francis at ti.com>
> > Signed-off-by: Dhruva Gole <d-gole at ti.com>
> > ---
> > 
> > No changes from v1, just picked Neha's ack and rebased on master again.
> > Link to v1:
> > https://lore.kernel.org/u-boot/20240612062351.3690091-1-d-gole@ti.com/
> > 
> >  arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi | 33 +++++++++++++++++++-
> >  1 file changed, 32 insertions(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi b/arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi
> > index fb2032068d1c..5e2248a4a668 100644
> > --- a/arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi
> > +++ b/arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi
> > @@ -69,6 +69,23 @@
> >  		};
> >  	};
> >  
> > +	tifsstub-gp {
> > +		filename = "tifsstub.bin_gp";
> > +		ti-secure-rom {
> > +			content = <&tifsstub_gp>;
> > +			core = "secure";
> > +			load = <0x60000>;
> > +			sw-rev = <CONFIG_K3_X509_SWRV>;
> > +			keyfile = "ti-degenerate-key.pem";
> > +			tifsstub;
> > +		};
> > +		tifsstub_gp: tifsstub-gp.bin {
> > +			filename = "ti-sysfw/ti-fs-stub-firmware-am62x-gp.bin";
> > +			type = "blob-ext";
> > +			optional;
> > +		};
> > +	};
> > +
> >  	ti-spl_unsigned {
> >  		filename = "tispl.bin_unsigned";
> >  		pad-byte = <0xff>;
> > @@ -105,6 +122,19 @@
> >  					};
> >  				};
> >  
> > +				tifsstub-gp {
> > +					description = "tifsstub";
> > +					type = "firmware";
> > +					arch = "arm32";
> > +					compression = "none";
> > +					os = "tifsstub-gp";
> > +					load = <0x9dc00000>;
> > +					entry = <0x9dc00000>;
> 
> Is this stub position independent? Or is this address compiled in at 
> build time? We have some variants of 62x that don't have these addresses 
> backed by DRAM.

The stub is not position independent and is indeed fixed at build time.
Can you talk more about these am62x variants that don't have the address
backed by DRAM? What would be the suggested address range in those
cases?

For BeaglePlay atleast I don't see an issue. So I don't think we'd have
issues with this patch in particular?

-- 
Best regards,
Dhruva Gole <d-gole at ti.com>