[PATCH 2/3] rockchip: fix wrong PCI range address in rk3568 dtsi

Etienne Dublé etienne.duble at imag.fr
Tue Jun 25 08:47:16 CEST 2024


Hi Quentin,

Le 24/06/2024 à 15:15, Quentin Schulz a écrit :
> Hi Etienne,
>
> On 6/24/24 2:40 PM, ETIENNE DUBLE wrote:
>> One of the PCI ranges was wrong in this device tree.
>> When testing with a FriendlyElec Nanopi R5C board, the
>> 2nd ethernet interface (labelled "wan") was not working
>> in u-boot because of that.
>>
>> With the correct value (found in FriendlyElec's downstream
>> u-boot repository), this 2nd ethernet interface now works.
>>
>> Signed-off-by: Etienne Dublé <etienne.duble at imag.fr>
>> ---
>>
>>   dts/upstream/src/arm64/rockchip/rk3568.dtsi | 2 +-
>
> dts/upstream is only for patches coming from **merged** Linux kernel 
> (i.e. releases or -rc releases or master branch from Linus Torvalds).
>
> We do not accept U-Boot-only patches in dts/upstream.
>
> Please submit the patch to the Linux kernel first and it will 
> eventually make it to that directory either via a 
> dts/update-dts-subtree.sh pull or dts/update-dts-subtree.sh pick. 
> Depending on maintainer's opinion, fixing the range in 
> arch/arm/dts/rk3568-u-boot.dtsi could be an option, but we really need 
> the patch sent to upstream Linux kernel community first.
>
> c.f. https://www.kernel.org/doc/html/v6.5/process/submitting-patches.html

I see, I will look at it.
In version 2 of the series I will remove this second patch and just 
mention that we are waiting for this problem to be fixed upstream, in 
the cover letter.

Cheers,
Etienne

-- 
Etienne Dublé
CNRS / LIG - Bâtiment IMAG
700 avenue Centrale - 38401 St Martin d'Hères
Bureau 426 - Tel 0457421431


More information about the U-Boot mailing list