[PATCH] zlib: Fix big performance regression

Joakim Tjernlund Joakim.Tjernlund at infinera.com
Thu Jun 27 16:41:21 CEST 2024


On Thu, 2024-06-27 at 10:25 +0200, Christophe Leroy wrote:
> Commit 340fdf1303dc ("zlib: Port fix for CVE-2016-9841 to U-Boot")
> brings a big performance regression in inflate_fast(), which leads
> to watchdog timer reset on powerpc 8xx.
> 
> It looks like that commit does more than what it describe, it
> especially removed an important optimisation that was doing copies
> using halfwords instead of bytes. That unexpected change multiplied
> by almost 4 the time spent in inflate_fast() and increased by 40%
> the overall time needed to uncompress linux kernel image.
> 
> So partially revert that commit but keep post incrementation as it
> is the initial purpose of said commit.
> 
> Fixes: 340fdf1303dc ("zlib: Port fix for CVE-2016-9841 to U-Boot")
> Signed-off-by: Christophe Leroy <christophe.leroy at csgroup.eu>
> ---

Thanks for looking after my old optimization :)

 Jocke


More information about the U-Boot mailing list