[PATCH] board: rockchip: add Rockchip Toybrick TB-RK3588X board

[Elon Zhang]

Hi Tom,

On 2/29/2024 23:08, Tom Rini wrote:
> On Thu, Feb 29, 2024 at 08:04:16PM +0800, Elon Zhang wrote:
>
>> TB-RK3588X board is a Rockchip Toybrick RK3588 based development board.
>>
>> Specification:
>> 	Rockchip Rk3588 SoC
>> 	4x ARM Cortex-A76, 4x ARM Cortex-A55
>> 	8/16GB Memory LPDDR4x
>> 	Mali G610MC4 GPU
>> 	2× MIPI-CSI0 Connector
>> 	1x 2Lanes PCIe3.0 Connector
>> 	1x SATA3.0 Connector
>> 	32GB eMMC Module
>> 	2x USB 2.0, 2x USB 3.0
>> 	1x HDMI Output, 1x HDMI Input
>> 	2x Ethernet Port
>>
>> Functions work normally:
>> 	[1] USB2.0 Host
>> 	[2] Ethernet0 with PHY RTL8211F
>>
>> More information can be obtained from the following websites:
>> 	[1] https://t.rock-chips.com/en/wiki/EN/tb-rk3588x_en/index.html
>> 	[2] http://t.rock-chips.com/
>>
>> Kernel commits:
>> 	8ffe365f8dc7 ("arm64: dts: rockchip: Add devicetree support for TB-RK3588X board")
>> 	7140387ff49d ("dt-bindings: arm: rockchip: Add Toybrick TB-RK3588X")
>>
>> Signed-off-by: Elon Zhang <zhangzj at rock-chips.com>
> [snip]
>> +config BOARD_SPECIFIC_OPTIONS # dummy
>> +	def_bool y
> Is this just a copy/paste thing that keeps getting re-used? Ideally,
> BOARD_SPECIFIC_OPTIONS shouldn't exist and it's either a select/imply at
> the TARGET_... level or something in the defconfig. But having an empty
> one is very confusing.
Yes... It will be removed later. Thanks for review!

Best regards,
Elon
>