[PATCH 5/8] clk: qcom: add driver for SM8150 SoC
Caleb Connolly
caleb.connolly at linaro.org
Fri Mar 1 18:16:01 CET 2024
On 29/02/2024 14:21, Volodymyr Babchuk wrote:
> Add clock, reset and power domain driver for SM8150. Driver code is
> based on the similar U-Boot drivers. All constants are taken from the
> corresponding Linux driver.
>
> This driver supports clock rate setting only for the debug UART and
> RGMII/Ethernet modules, because this is all I can test right now.
>
> Signed-off-by: Volodymyr Babchuk <volodymyr_babchuk at epam.com>
> ---
>
> drivers/clk/qcom/Kconfig | 8 ++
> drivers/clk/qcom/Makefile | 1 +
> drivers/clk/qcom/clock-qcom.h | 1 +
> drivers/clk/qcom/clock-sm8150.c | 234 ++++++++++++++++++++++++++++++++
> 4 files changed, 244 insertions(+)
> create mode 100644 drivers/clk/qcom/clock-sm8150.c
>
> diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig
> index 0df0d1881a..18ccf6a45e 100644
> --- a/drivers/clk/qcom/Kconfig
> +++ b/drivers/clk/qcom/Kconfig
> @@ -47,6 +47,14 @@ config CLK_QCOM_SDM845
> on the Snapdragon 845 SoC. This driver supports the clocks
> and resets exposed by the GCC hardware block.
>
> +config CLK_QCOM_SM8150
> + bool "Qualcomm SM8150 GCC"
> + select CLK_QCOM
> + help
> + Say Y here to enable support for the Global Clock Controller
> + on the Snapdragon 8150 SoC. This driver supports the clocks
> + and resets exposed by the GCC hardware block.
> +
> endmenu
>
> endif
> diff --git a/drivers/clk/qcom/Makefile b/drivers/clk/qcom/Makefile
> index cb179fdac5..12c09ba19e 100644
> --- a/drivers/clk/qcom/Makefile
> +++ b/drivers/clk/qcom/Makefile
> @@ -8,3 +8,4 @@ obj-$(CONFIG_CLK_QCOM_APQ8016) += clock-apq8016.o
> obj-$(CONFIG_CLK_QCOM_APQ8096) += clock-apq8096.o
> obj-$(CONFIG_CLK_QCOM_IPQ4019) += clock-ipq4019.o
> obj-$(CONFIG_CLK_QCOM_QCS404) += clock-qcs404.o
> +obj-$(CONFIG_CLK_QCOM_SM8150) += clock-sm8150.o
> diff --git a/drivers/clk/qcom/clock-qcom.h b/drivers/clk/qcom/clock-qcom.h
> index 12a1eaec2b..41107df216 100644
> --- a/drivers/clk/qcom/clock-qcom.h
> +++ b/drivers/clk/qcom/clock-qcom.h
> @@ -9,6 +9,7 @@
>
> #define CFG_CLK_SRC_CXO (0 << 8)
> #define CFG_CLK_SRC_GPLL0 (1 << 8)
> +#define CFG_CLK_SRC_GPLL7_MAIN (3 << 8)
Please follow the existing scheme and remove the _MAIN suffix.
I'd also be fine with converting all of these definitions to follow how
the Linux drivers name them.
> #define CFG_CLK_SRC_GPLL0_EVEN (6 << 8)
> #define CFG_CLK_SRC_MASK (7 << 8)
>
> diff --git a/drivers/clk/qcom/clock-sm8150.c b/drivers/clk/qcom/clock-sm8150.c
> new file mode 100644
> index 0000000000..e23dbccdd3
> --- /dev/null
> +++ b/drivers/clk/qcom/clock-sm8150.c
> @@ -0,0 +1,234 @@
> +// SPDX-License-Identifier: BSD-3-Clause
> +/*
> + * Clock drivers for Qualcomm SM8150
> + *
> + * Volodymyr Babchuk <volodymyr_babchuk at epam.com>
> + * Copyright (c) 2024 EPAM Systems.
> + *
> + * Based on U-Boot driver for SDM845. Constants are taken from the Linux driver.
> + */
> +
> +#include <clk-uclass.h>
> +#include <dm.h>
> +#include <linux/delay.h>
This header is unused
> +#include <errno.h>
> +#include <asm/io.h>
> +#include <linux/bitops.h>
> +#include <dt-bindings/clock/qcom,gcc-sm8150.h>
> +
> +#include "clock-qcom.h"
> +
> +static struct pll_vote_clk gpll7_vote_clk = {
> + .status = 0x1a000,
> + .status_bit = BIT(31),
> + .ena_vote = 0x52000,
> + .vote_bit = BIT(7),
> +};
> +
> +static const struct freq_tbl ftbl_gcc_qupv3_wrap0_s0_clk_src[] = {
> + F(7372800, CFG_CLK_SRC_GPLL0_EVEN, 1, 384, 15625),
> + F(14745600, CFG_CLK_SRC_GPLL0_EVEN, 1, 768, 15625),
> + F(19200000, CFG_CLK_SRC_CXO, 1, 0, 0),
> + F(29491200, CFG_CLK_SRC_GPLL0_EVEN, 1, 1536, 15625),
> + F(32000000, CFG_CLK_SRC_GPLL0_EVEN, 1, 8, 75),
> + F(48000000, CFG_CLK_SRC_GPLL0_EVEN, 1, 4, 25),
> + F(64000000, CFG_CLK_SRC_GPLL0_EVEN, 1, 16, 75),
> + F(80000000, CFG_CLK_SRC_GPLL0_EVEN, 1, 4, 15),
> + F(96000000, CFG_CLK_SRC_GPLL0_EVEN, 1, 8, 25),
> + F(100000000, CFG_CLK_SRC_GPLL0_EVEN, 3, 0, 0),
> + F(102400000, CFG_CLK_SRC_GPLL0_EVEN, 1, 128, 375),
> + F(112000000, CFG_CLK_SRC_GPLL0_EVEN, 1, 28, 75),
> + F(117964800, CFG_CLK_SRC_GPLL0_EVEN, 1, 6144, 15625),
> + F(120000000, CFG_CLK_SRC_GPLL0_EVEN, 2.5, 0, 0),
> + F(128000000, CFG_CLK_SRC_GPLL0, 1, 16, 75),
> + { }
> +};
> +
> +static const struct freq_tbl ftbl_gcc_emac_rgmii_clk_src[] = {
> + F(2500000, CFG_CLK_SRC_CXO, 1, 25, 192),
> + F(5000000, CFG_CLK_SRC_CXO, 1, 25, 96),
> + F(19200000, CFG_CLK_SRC_CXO, 1, 0, 0),
> + F(25000000, CFG_CLK_SRC_GPLL0_EVEN, 12, 0, 0),
> + F(50000000, CFG_CLK_SRC_GPLL0_EVEN, 6, 0, 0),
> + F(125000000, CFG_CLK_SRC_GPLL7_MAIN, 4, 0, 0),
> + F(250000000, CFG_CLK_SRC_GPLL7_MAIN, 2, 0, 0),
> + { }
> +};
> +
> +static const struct bcr_regs uart2_regs = {
> + .cfg_rcgr = 0x1814C,
> + .cmd_rcgr = 0x18148,
> + .M = 0x18150,
> + .N = 0x18154,
> + .D = 0x18158,
> +};
> +
> +static const struct bcr_regs rgmii_regs = {
> + .cfg_rcgr = 0x6020,
> + .cmd_rcgr = 0x601C,
> + .M = 0x6024,
> + .N = 0x6028,
> + .D = 0x602C,
> +};
> +
> +static ulong sm8150_clk_set_rate(struct clk *clk, ulong rate)
> +{
> + struct msm_clk_priv *priv = dev_get_priv(clk->dev);
> + const struct freq_tbl *freq;
> +
> + switch (clk->id) {
> + case GCC_QUPV3_WRAP1_S4_CLK: /* UART2 aka debug-uart */
> + freq = qcom_find_freq(ftbl_gcc_qupv3_wrap0_s0_clk_src, rate);
> + clk_rcg_set_rate_mnd(priv->base, &uart2_regs,
> + freq->pre_div, freq->m, freq->n, freq->src, 16);
> + return freq->freq;
> + case GCC_EMAC_RGMII_CLK:
> + freq = qcom_find_freq(ftbl_gcc_emac_rgmii_clk_src, rate);
> + clk_rcg_set_rate_mnd(priv->base, &rgmii_regs,
> + freq->pre_div, freq->m, freq->n, freq->src, 8);
> +
> + return freq->freq;
> + default:
> + pr_err("Don't know how to set clk id %ld\n", clk->id);
> + return -ENODEV;
I think -EINVAL would be a better fit here.
> + }
> +}
> +
> +static const struct gate_clk sm8150_clks[] = {
> + GATE_CLK(GCC_QUPV3_WRAP0_S0_CLK, 0x5200c, 0x00000400),
> + GATE_CLK(GCC_QUPV3_WRAP0_S1_CLK, 0x5200c, 0x00000800),
> + GATE_CLK(GCC_QUPV3_WRAP0_S2_CLK, 0x5200c, 0x00001000),
> + GATE_CLK(GCC_QUPV3_WRAP0_S3_CLK, 0x5200c, 0x00002000),
> + GATE_CLK(GCC_QUPV3_WRAP0_S4_CLK, 0x5200c, 0x00004000),
> + GATE_CLK(GCC_QUPV3_WRAP0_S5_CLK, 0x5200c, 0x00008000),
> + GATE_CLK(GCC_QUPV3_WRAP1_S0_CLK, 0x5200c, 0x00400000),
> + GATE_CLK(GCC_QUPV3_WRAP1_S1_CLK, 0x5200c, 0x00800000),
> + GATE_CLK(GCC_QUPV3_WRAP1_S3_CLK, 0x5200c, 0x02000000),
> + GATE_CLK(GCC_QUPV3_WRAP1_S4_CLK, 0x5200c, 0x04000000),
> + GATE_CLK(GCC_QUPV3_WRAP1_S5_CLK, 0x5200c, 0x08000000),
> + GATE_CLK(GCC_QUPV3_WRAP_0_M_AHB_CLK, 0x5200c, 0x00000040),
> + GATE_CLK(GCC_QUPV3_WRAP_0_S_AHB_CLK, 0x5200c, 0x00000080),
> + GATE_CLK(GCC_QUPV3_WRAP_1_M_AHB_CLK, 0x5200c, 0x00100000),
> + GATE_CLK(GCC_QUPV3_WRAP_1_S_AHB_CLK, 0x5200c, 0x00200000),
> + GATE_CLK(GCC_SDCC2_AHB_CLK, 0x14008, 0x00000001),
> + GATE_CLK(GCC_SDCC2_APPS_CLK, 0x14004, 0x00000001),
> + GATE_CLK(GCC_SDCC4_AHB_CLK, 0x16008, 0x00000001),
> + GATE_CLK(GCC_SDCC4_APPS_CLK, 0x16004, 0x00000001),
> + GATE_CLK(GCC_UFS_CARD_AHB_CLK, 0x75010, 0x00000001),
> + GATE_CLK(GCC_UFS_CARD_AXI_CLK, 0x7500c, 0x00000001),
> + GATE_CLK(GCC_UFS_CARD_CLKREF_CLK, 0x8c004, 0x00000001),
> + GATE_CLK(GCC_UFS_CARD_ICE_CORE_CLK, 0x75058, 0x00000001),
> + GATE_CLK(GCC_UFS_CARD_PHY_AUX_CLK, 0x7508c, 0x00000001),
> + GATE_CLK(GCC_UFS_CARD_RX_SYMBOL_0_CLK, 0x75018, 0x00000001),
> + GATE_CLK(GCC_UFS_CARD_RX_SYMBOL_1_CLK, 0x750a8, 0x00000001),
> + GATE_CLK(GCC_UFS_CARD_TX_SYMBOL_0_CLK, 0x75014, 0x00000001),
> + GATE_CLK(GCC_UFS_CARD_UNIPRO_CORE_CLK, 0x75054, 0x00000001),
> + GATE_CLK(GCC_UFS_MEM_CLKREF_CLK, 0x8c000, 0x00000001),
> + GATE_CLK(GCC_UFS_PHY_AHB_CLK, 0x77010, 0x00000001),
> + GATE_CLK(GCC_UFS_PHY_AXI_CLK, 0x7700c, 0x00000001),
> + GATE_CLK(GCC_UFS_PHY_ICE_CORE_CLK, 0x77058, 0x00000001),
> + GATE_CLK(GCC_UFS_PHY_PHY_AUX_CLK, 0x7708c, 0x00000001),
> + GATE_CLK(GCC_UFS_PHY_RX_SYMBOL_0_CLK, 0x77018, 0x00000001),
> + GATE_CLK(GCC_UFS_PHY_RX_SYMBOL_1_CLK, 0x770a8, 0x00000001),
> + GATE_CLK(GCC_UFS_PHY_TX_SYMBOL_0_CLK, 0x77014, 0x00000001),
> + GATE_CLK(GCC_UFS_PHY_UNIPRO_CORE_CLK, 0x77054, 0x00000001),
> + GATE_CLK(GCC_USB30_PRIM_MASTER_CLK, 0x0f00c, 0x00000001),
> + GATE_CLK(GCC_USB30_PRIM_MOCK_UTMI_CLK, 0x0f014, 0x00000001),
> + GATE_CLK(GCC_USB30_PRIM_SLEEP_CLK, 0x0f010, 0x00000001),
> + GATE_CLK(GCC_USB30_SEC_MASTER_CLK, 0x1000c, 0x00000001),
> + GATE_CLK(GCC_USB30_SEC_MOCK_UTMI_CLK, 0x10014, 0x00000001),
> + GATE_CLK(GCC_USB30_SEC_SLEEP_CLK, 0x10010, 0x00000001),
> + GATE_CLK(GCC_USB3_PRIM_CLKREF_CLK, 0x8c008, 0x00000001),
> + GATE_CLK(GCC_USB3_PRIM_PHY_AUX_CLK, 0x0f04c, 0x00000001),
> + GATE_CLK(GCC_USB3_PRIM_PHY_COM_AUX_CLK, 0x0f050, 0x00000001),
> + GATE_CLK(GCC_USB3_PRIM_PHY_PIPE_CLK, 0x0f054, 0x00000001),
> + GATE_CLK(GCC_USB3_SEC_CLKREF_CLK, 0x8c028, 0x00000001),
> + GATE_CLK(GCC_USB3_SEC_PHY_AUX_CLK, 0x1004c, 0x00000001),
> + GATE_CLK(GCC_USB3_SEC_PHY_PIPE_CLK, 0x10054, 0x00000001),
> + GATE_CLK(GCC_USB3_SEC_PHY_COM_AUX_CLK, 0x10050, 0x00000001),
> + GATE_CLK(GCC_EMAC_AXI_CLK, 0x06010, 0x00000001),
> + GATE_CLK(GCC_EMAC_SLV_AHB_CLK, 0x06014, 0x00000001),
> + GATE_CLK(GCC_EMAC_PTP_CLK, 0x06034, 0x00000001),
> + GATE_CLK(GCC_EMAC_RGMII_CLK, 0x06018, 0x00000001),
> +};
> +
> +static int sm8150_clk_enable(struct clk *clk)
> +{
> + struct msm_clk_priv *priv = dev_get_priv(clk->dev);
> +
> + clk_enable_gpll0(priv->base, &gpll7_vote_clk);
This will write to the GPLL for every single clock, I think you're
missing a switch case block here.
> + qcom_gate_clk_en(priv, clk->id);
> +
> + return 0;
> +}
> +
> +static const struct qcom_reset_map sm8150_gcc_resets[] = {
> + [GCC_EMAC_BCR] = { 0x6000 },
> + [GCC_GPU_BCR] = { 0x71000 },
> + [GCC_MMSS_BCR] = { 0xb000 },
> + [GCC_NPU_BCR] = { 0x4d000 },
> + [GCC_PCIE_0_BCR] = { 0x6b000 },
> + [GCC_PCIE_0_PHY_BCR] = { 0x6c01c },
> + [GCC_PCIE_1_BCR] = { 0x8d000 },
> + [GCC_PCIE_1_PHY_BCR] = { 0x8e01c },
> + [GCC_PCIE_PHY_BCR] = { 0x6f000 },
> + [GCC_PDM_BCR] = { 0x33000 },
> + [GCC_PRNG_BCR] = { 0x34000 },
> + [GCC_QSPI_BCR] = { 0x24008 },
> + [GCC_QUPV3_WRAPPER_0_BCR] = { 0x17000 },
> + [GCC_QUPV3_WRAPPER_1_BCR] = { 0x18000 },
> + [GCC_QUPV3_WRAPPER_2_BCR] = { 0x1e000 },
> + [GCC_QUSB2PHY_PRIM_BCR] = { 0x12000 },
> + [GCC_QUSB2PHY_SEC_BCR] = { 0x12004 },
> + [GCC_USB3_PHY_PRIM_BCR] = { 0x50000 },
> + [GCC_USB3_DP_PHY_PRIM_BCR] = { 0x50008 },
> + [GCC_USB3_PHY_SEC_BCR] = { 0x5000c },
> + [GCC_USB3PHY_PHY_SEC_BCR] = { 0x50010 },
> + [GCC_SDCC2_BCR] = { 0x14000 },
> + [GCC_SDCC4_BCR] = { 0x16000 },
> + [GCC_TSIF_BCR] = { 0x36000 },
> + [GCC_UFS_CARD_BCR] = { 0x75000 },
> + [GCC_UFS_PHY_BCR] = { 0x77000 },
> + [GCC_USB30_PRIM_BCR] = { 0xf000 },
> + [GCC_USB30_SEC_BCR] = { 0x10000 },
> + [GCC_USB_PHY_CFG_AHB2PHY_BCR] = { 0x6a000 },
> +};
> +
> +static const struct qcom_power_map sm8150_gcc_power_domains[] = {
This is really nice! Certainly better than my approach [1].
Please reorder the patches so that the power domain driver is added
before this so we don't break future bisects.
> + [EMAC_GDSC] = { 0x6004 },
> + [PCIE_0_GDSC] = { 0x6b004 },
> + [PCIE_1_GDSC] = { 0x8d004 },
> + [UFS_CARD_GDSC] = { 0x75004 },
> + [UFS_PHY_GDSC] = { 0x7704 },
> + [USB30_PRIM_GDSC] = { 0x6004 },
> + [USB30_SEC_GDSC] = { 0x10004 },
> +};
> +
> +
> +static struct msm_clk_data sm8150_clk_data = {
> + .resets = sm8150_gcc_resets,
> + .num_resets = ARRAY_SIZE(sm8150_gcc_resets),
> + .clks = sm8150_clks,
> + .num_clks = ARRAY_SIZE(sm8150_clks),
> + .power_domains = sm8150_gcc_power_domains,
> + .num_power_domains = ARRAY_SIZE(sm8150_gcc_power_domains),
> +
> + .enable = sm8150_clk_enable,
> + .set_rate = sm8150_clk_set_rate,
> +};
> +
> +static const struct udevice_id gcc_sm8150_of_match[] = {
> + {
> + .compatible = "qcom,gcc-sm8150",
> + .data = (ulong)&sm8150_clk_data,
> + },
> + { }
> +};
> +
> +U_BOOT_DRIVER(gcc_sm8150) = {
> + .name = "gcc_sm8150",
> + .id = UCLASS_NOP,
> + .of_match = gcc_sm8150_of_match,
> + .bind = qcom_cc_bind,
> + .flags = DM_FLAG_PRE_RELOC,
> +};
Just in case it's useful to you, I have some work in progress patches
for dumping the clock configuration, I hope to upstream these eventually
but in the mean time you can find them here:
https://git.codelinaro.org/linaro/qcomlt/u-boot/-/commit/af651f236f221cc21227e68c3795b52705a4f12d
[1]:
https://lore.kernel.org/u-boot/20240131-b4-qcom-livetree-v1-5-4071c0787db0@linaro.org/
--
// Caleb (they/them)
More information about the U-Boot
mailing list