[PATCH v1 2/2] rockchip: spl-boot-order: Improve debugging message when device isn't found

Quentin Schulz quentin.schulz at theobroma-systems.com
Mon Mar 4 10:44:53 CET 2024


Hi Christopher,

On 3/2/24 15:50, Christopher Obbard wrote:
> [You don't often get email from chris.obbard at collabora.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
> 
> When debugging the SPL boot order, the node ID of a device which hasn't
> been found is printed but it can be quite hard to relate that to the
> specific devicetree node. To aid debugging, print the node path as well as
> the ID.
> 
> Original debug message:
> 
>      board_boot_order: could not map node @73c to a boot-device
> 
> With this patch applied this becomes e.g:
> 
>     board_boot_order: could not map node @73c (/spi at ff1d0000/flash at 0) to a boot-device
> 

Does it actually make sense to print the node "number" here (I have no 
clue what it represents and if it's useful for debugging)? Can't we just 
replace @%x with the node path (conf) directly instead?

Cheers,
Quentin


More information about the U-Boot mailing list