[PATCH v2] board: rockchip: add Rockchip Toybrick TB-RK3588X board

[Quentin Schulz]

Hi Elon,

On 3/1/24 09:50, Elon Zhang wrote:
> [You don't often get email from zhangzj at rock-chips.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
> 
> TB-RK3588X board is a Rockchip Toybrick RK3588 based development board.
> 
> Specification:
>          Rockchip Rk3588 SoC
>          4x ARM Cortex-A76, 4x ARM Cortex-A55
>          8/16GB Memory LPDDR4x
>          Mali G610MC4 GPU
>          2× MIPI-CSI0 Connector
>          1x 2Lanes PCIe3.0 Connector
>          1x SATA3.0 Connector
>          32GB eMMC Module
>          2x USB 2.0, 2x USB 3.0
>          1x HDMI Output, 1x HDMI Input
>          2x Ethernet Port
> 
> Functions work normally:
>          [1] USB2.0 Host
>          [2] Ethernet0 with PHY RTL8211F
> 
> More information can be obtained from the following websites:
>          [1] https://t.rock-chips.com/en/wiki/EN/tb-rk3588x_en/index.html
>          [2] http://t.rock-chips.com/
> 
> Kernel commits:
>          8ffe365f8dc7 ("arm64: dts: rockchip: Add devicetree support for TB-RK3588X board")
>          7140387ff49d ("dt-bindings: arm: rockchip: Add Toybrick TB-RK3588X")
> 
> Signed-off-by: Elon Zhang <zhangzj at rock-chips.com>
> ---
> Changes since v1:
>    - Remove BOARD_SPECIFIC_OPTIONS in board Kconfig
> ---
>   arch/arm/dts/rk3588-toybrick-x0-u-boot.dtsi   |  12 +
>   arch/arm/dts/rk3588-toybrick-x0.dts           | 672 ++++++++++++++++++
>   arch/arm/mach-rockchip/rk3588/Kconfig         |  25 +
>   board/rockchip/toybrick_rk3588/Kconfig        |  12 +
>   board/rockchip/toybrick_rk3588/MAINTAINERS    |   8 +
>   board/rockchip/toybrick_rk3588/Makefile       |   6 +
>   .../toybrick_rk3588/toybrick-rk3588.c         |  39 +
>   configs/toybrick-rk3588_defconfig             |  82 +++
>   doc/board/rockchip/rockchip.rst               |   1 +
>   include/configs/toybrick_rk3588.h             |  15 +
>   10 files changed, 872 insertions(+)
>   create mode 100644 arch/arm/dts/rk3588-toybrick-x0-u-boot.dtsi
>   create mode 100644 arch/arm/dts/rk3588-toybrick-x0.dts
>   create mode 100644 board/rockchip/toybrick_rk3588/Kconfig
>   create mode 100644 board/rockchip/toybrick_rk3588/MAINTAINERS
>   create mode 100644 board/rockchip/toybrick_rk3588/Makefile
>   create mode 100644 board/rockchip/toybrick_rk3588/toybrick-rk3588.c
>   create mode 100644 configs/toybrick-rk3588_defconfig
>   create mode 100644 include/configs/toybrick_rk3588.h
> 
> diff --git a/arch/arm/dts/rk3588-toybrick-x0-u-boot.dtsi b/arch/arm/dts/rk3588-toybrick-x0-u-boot.dtsi
> new file mode 100644
> index 0000000000..1aeb5410e4
> --- /dev/null
> +++ b/arch/arm/dts/rk3588-toybrick-x0-u-boot.dtsi
> @@ -0,0 +1,12 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Copyright (c) 2024 Rockchip Electronics Co., Ltd.
> + */
> +
> +#include "rk3588-u-boot.dtsi"
> +
> +/ {
> +       chosen {
> +               u-boot,spl-boot-order = "same-as-spl", &sdhci;
> +       };
> +};
> diff --git a/arch/arm/dts/rk3588-toybrick-x0.dts b/arch/arm/dts/rk3588-toybrick-x0.dts
> new file mode 100644
> index 0000000000..f3f7c1d35e
> --- /dev/null
> +++ b/arch/arm/dts/rk3588-toybrick-x0.dts

If I'm not mistaken, the DTS in this patch is not the same as the one 
that was merged in upstream Linux, please use the one from upstream 
Linux kernel.

https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git/tree/arch/arm64/boot/dts/rockchip/rk3588-toybrick-x0.dts?h=v6.9-armsoc/dts64

Cheers,
Quentin