[PATCH 1/2] board: phytec: common: phytec_som_detection: Add phytec_get_som_type

Benjamin Hahn B.Hahn at phytec.de
Mon Mar 4 17:08:10 CET 2024


On 04.03.24 15:42, Fabio Estevam wrote:
> On Mon, Mar 4, 2024 at 9:31 AM Benjamin Hahn <B.Hahn at phytec.de> wrote:
>> Add a function that gets the som_type from the EEPROM.
>> Add an enum for the som_type.
>>
>> Signed-off-by: Benjamin Hahn <B.Hahn at phytec.de>
> Your series does not even build:
>
> board/phytec/common/phytec_som_detection.c: In function ‘phytec_get_som_type’:
> board/phytec/common/phytec_som_detection.c:210:18: error: ‘struct
> phytec_eeprom_data’ has no member named ‘valid’
>    210 |         if (!data->valid || data->data.api_rev < PHYTEC_API_REV2)
>        |                  ^~
> board/phytec/common/phytec_som_detection.c:210:39: error: ‘union
> <anonymous>’ has no member named ‘api_rev’
>    210 |         if (!data->valid || data->data.api_rev < PHYTEC_API_REV2)
>        |                                       ^
> board/phytec/common/phytec_som_detection.c:213:26: error: ‘union
> <anonymous>’ has no member named ‘data’
>    213 |         return data->data.data.data_api2.som_type;
>        |                          ^
> board/phytec/common/phytec_som_detection.c:214:1: warning: control
> reaches end of non-void function [-Wreturn-type]
>    214 | }
>        | ^

Oh, I'm very sorry about that. Seems like I made some mistakes when 
porting the patches to upstream.

I sent a v2, where I fixed them.

Benjamin



More information about the U-Boot mailing list