[PATCH v2] initcall: break loop immediately on failure

[Dan Carpenter]

On Tue, Mar 05, 2024 at 02:55:13PM +0000, Caleb Connolly wrote:
> The current ordering always results in func pointing to the next
> function in the init_sequence. e.g. if fdtdec_setup() fails, ret will
> be set to the error code, then func will be updated to point to
> initf_malloc(), only then is ret checked and the loop broken. The end
> result of this is that the "initcall failed at ..." error will point you
> to initf_malloc(), when the error actually occured in fdtdec_setup()!
> 
> This can be quite confusing and result in a lot of time wasted debugging
> code that has nothing to do with the failure (ask me how I know :P).
> 
> Adjust the for loop to check ret immediately after the call and break
> early so that func will correctly reference the failed function.
> 
> Signed-off-by: Caleb Connolly <caleb.connolly at linaro.org>
> ---
> Changes in v2:
> - Don't drop the initialisation of ret (thanks Dan!).
> - Link to v1: https://lore.kernel.org/u-boot/20240219183519.2183405-1-caleb.connolly@linaro.org/
> 
> Cc: Dan Carpenter <dan.carpenter at linaro.org>

Awesome.  Thanks!

Reviewed-by: Dan Carpenter <dan.carpenter at linaro.org>

regards,
dan carpenter