[PATCH] cmd: sbi: Correctly display unknown implementation IDs
Conor Dooley
conor at kernel.org
Wed Mar 6 16:22:03 CET 2024
On Wed, Mar 06, 2024 at 03:44:02PM +0100, Heinrich Schuchardt wrote:
> For an unknown implementation ID an output like
>
> SBI 1.0Unknown implementation ID 16777216
> Extensions:
> sbi_set_timer
> ...
>
> was shown. The number 16777216 is not the implementation ID.
>
> * Show the correct number
> * Use a hexadecimal output format
> * Add a missing line feed
>
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt at canonical.com>
Reviewed-by: Conor Dooley <conor.dooley at microchip.com>
Thanks,
Conor.
> cmd/riscv/sbi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/cmd/riscv/sbi.c b/cmd/riscv/sbi.c
> index 9daf0e247ad..87f7966f06b 100644
> --- a/cmd/riscv/sbi.c
> +++ b/cmd/riscv/sbi.c
> @@ -99,7 +99,7 @@ static int do_sbi(struct cmd_tbl *cmdtp, int flag, int argc,
> }
> }
> if (i == ARRAY_SIZE(implementations))
> - printf("Unknown implementation ID %ld", ret);
> + printf("\nUnknown implementation ID 0x%x", impl_id);
> }
> printf("\nMachine:\n");
> ret = sbi_get_mvendorid(&mvendorid);
> --
> 2.43.0
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20240306/21479bab/attachment.sig>
More information about the U-Boot
mailing list