[PATCH v3] test/py: reset: Add a test for reset command

[Michal Simek]

On 3/7/24 08:56, Angelo Dureghello wrote:
> Hi Tom,
> 
> On 07/03/24 1:10 AM, Tom Rini wrote:
>> On Thu, Mar 07, 2024 at 12:36:42AM +0100, Angelo Dureghello wrote:
>>> Hi,
>>>
>>> On 05/03/24 1:34 PM, Michal Simek wrote:
>>>>
>>>>
>>>> On 3/3/24 22:58, Angelo Dureghello wrote:
>>>>> Hi Tom,
>>>>>> On Tue, Feb 20, 2024 at 01:11:38PM +0530, Love Kumar wrote:
>>>>>>> Add a test for reset commands which performs resetting of
>>>>>>> CPU, It does COLD reset by default and WARM reset with -w
>>>>>>> option. Signed-off-by: Love Kumar <love.kumar at amd.com>
>>>>>>> Reviewed-by: Tom Rini <trini at konsulko.com> --- Changes in
>>>>>>> v2: - Set bootmode through boardenv if modeboot is not
>>>>>>> defined Changes in v3: - Fix the issue with bad pattern
>>>>>>> found on console --- test/py/tests/test_reset.py | 61
>>>>>>> +++++++++++++++++++++++++++++++++++++ 1 file changed, 61
>>>>>>> insertions(+) create mode 100644 test/py/tests/test_reset.py
>>>>>> I had hoped this was all sorted out now, but both this and the
>>>>>> saveenv test cause qemu_m68k to fail now. See:
>>>>>> https://source.denx.de/u-boot/u-boot/-/jobs/791635
>>>>> looking into this.
>>>>
>>>> Is reset implemented in qemu? It should be skipped if it is not.
>>>>
>>> yes, seems not implemented
>>>
>>> => reset
>>> => reset -w
>>> =>
>>> =>
>>>
>>> Not finding any trace in the qemu code related to
>>>
>>> out_8(&rcm->rcr, RCM_RCR_SOFTRST);
>>
>> Does reset work on the real HW, or can you not test? What I'm wondering
>> is if we have a missing feature on the board/arch code (and should
>> disable the reset command) or a problem with QEMU.
>>
> I don't have the exact hardware (m5208evb) but:
> 
> 1) i checked by tracing that on qemu the reset function is properly called
> 
> => reset
> resetting, RCR fc0a0000
> 
> 2) reset register address is correct. I checked also that writing directly to it 
> by mw.b does now produce the reset,
> 
> => reset
> resetting, RCR fc0a0000
> 
> => mw.b 0xfc0a0000 80
> =>
> 
> So looks not implemented in qemu.

ok. That means that we shouldn't run reset test inside CI loop for this platform.

Thanks,
Michal