[PATCH 1/2] lmb: Avoid to add identical region in lmb_add_region_flags()

Patrice CHOTARD patrice.chotard at foss.st.com
Tue Mar 12 12:44:16 CET 2024



On 3/11/24 20:32, Francesco Dolcini wrote:
> Hello Patrice,
> 
> On Mon, Mar 11, 2024 at 03:39:17PM +0100, Patrice Chotard wrote:
>> In case lmb_add_region_flags() is called with the same parameter than
>> an already existing lmb and this lmb is adjacent to its previous lmb with
>> different flag, this lmb is added again.
> 
> Is this
> 
> On Mon, Mar 11, 2024 at 03:39:18PM +0100, Patrice Chotard wrote:
>> In case a new region is adjacent to a previous region with
>> similar flag, this region is merged with its predecessor, but no
>> check are done if this new added region is overlapping another region
>> present in lmb (see reserved[3] which overlaps reserved[4]).
> 
> or this, related to some
> 
> ERROR: reserving fdt memory region failed
> 
> message in your opinion?
> 
> More details in https://lore.kernel.org/all/fe9431c5-6806-1b7a-f9f4-dbe97ee13bba@toradex.com/

Hi Francesco

I observed also "ERROR: reserving fdt memory region failed" on STM32MP1 platform,
the issue was fixed using efi_add_memory_map() as done in this patch :

https://patchwork.ozlabs.org/project/uboot/patch/20240308101230.2595220-1-patrice.chotard@foss.st.com/

Thanks
Patrice

> 
> Francesco
> 


More information about the U-Boot mailing list