[PATCH] apalis-imx8: Fix sc_misc_otp_fuse_read() error check

[Peng Fan]

> -----Original Message-----
> From: Fabio Estevam <festevam at gmail.com>
> Sent: Wednesday, March 13, 2024 9:00 AM
> To: festevam at gmail.com
> Cc: Marcel Ziswiler <marcel.ziswiler at toradex.com>;
> hiago.franco at toradex.com; Francesco Dolcini
> <francesco.dolcini at toradex.com>; u-boot at lists.denx.de; Peng Fan
> <peng.fan at nxp.com>; joao.goncalves at toradex.com
> Subject: [PATCH] apalis-imx8: Fix sc_misc_otp_fuse_read() error check
> 
> Commit bfb3409d676f ("imx: toradex/apalis-imx8: correct SCU API usage")
> made an incorrect logic change in the error code check of
> sc_misc_otp_fuse_read():
> 
> -       if (scierr == SC_ERR_NONE) {
> +       if (scierr) {
>                 /* QP has one A72 core disabled */
>                 is_quadplus = ((val >> 4) & 0x3) != 0x0;
>         }
> 
> The other changes in this commit are correct.
> 
> sc_misc_otp_fuse_read() returns 0 on a successful fuse read.
> 
> This inversion causes board_mem_get_layout() to report incorrect RAM size.
> 
> Go back the original error check logic to fix the problem.
> 
> Fixes: bfb3409d676f ("imx: toradex/apalis-imx8: correct SCU API usage")
> Signed-off-by: Fabio Estevam <festevam at gmail.com>

Reviewed-by: Peng Fan <peng.fan at nxp.com>
> ---
>  board/toradex/apalis-imx8/apalis-imx8.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/board/toradex/apalis-imx8/apalis-imx8.c b/board/toradex/apalis-
> imx8/apalis-imx8.c
> index 2483a63c6733..49719f2f5533 100644
> --- a/board/toradex/apalis-imx8/apalis-imx8.c
> +++ b/board/toradex/apalis-imx8/apalis-imx8.c
> @@ -133,7 +133,7 @@ void board_mem_get_layout(u64
> *phys_sdram_1_start,
>  	struct tdx_user_fuses tdxramfuses;
>  	int scierr = sc_misc_otp_fuse_read(-1, 6, &val);
> 
> -	if (scierr) {
> +	if (!scierr) {
>  		/* QP has one A72 core disabled */
>  		is_quadplus = ((val >> 4) & 0x3) != 0x0;
>  	}
> --
> 2.34.1