[PATCH v3 14/14] qcom_defconfig: enable USB

[Caleb Connolly]

On 20/03/2024 05:40, Sumit Garg wrote:
> On Tue, 19 Mar 2024 at 17:52, Caleb Connolly <caleb.connolly at linaro.org> wrote:
>>
>> Enable support for the DWC3 USB controller and required dependencies for
>> Qualcomm boards, specifically the DB845c:
>> * IOMMU / SMMU
>> * USB high-speed PHYs
>> * Mass storage and ACM gadgets
>>
>> Signed-off-by: Caleb Connolly <caleb.connolly at linaro.org>
>> ---
>>  configs/qcom_defconfig | 49 ++++++++++++++++++++++++++-----------------------
>>  1 file changed, 26 insertions(+), 23 deletions(-)
>>
>> diff --git a/configs/qcom_defconfig b/configs/qcom_defconfig
>> index eebd0d74bd51..156c205284dd 100644
>> --- a/configs/qcom_defconfig
>> +++ b/configs/qcom_defconfig
>> @@ -12,42 +12,63 @@ CONFIG_BOOTSTD_FULL=y
>>  CONFIG_BOOTDELAY=1
>>  CONFIG_USE_PREBOOT=y
>>  CONFIG_SAVE_PREV_BL_INITRAMFS_START_ADDR=y
>>  CONFIG_SYS_CBSIZE=512
>> +# CONFIG_SYS_DEVICE_NULLDEV is not set
>>  CONFIG_LOG_MAX_LEVEL=9
>>  CONFIG_LOG_DEFAULT_LEVEL=4
>>  # CONFIG_DISPLAY_CPUINFO is not set
>>  CONFIG_DISPLAY_BOARDINFO_LATE=y
>>  CONFIG_CMD_BOOTMENU=y
>> +CONFIG_CMD_EEPROM=y
>> +CONFIG_SYS_I2C_EEPROM_BUS=2
>> +CONFIG_SYS_I2C_EEPROM_ADDR_LEN=2
>> +CONFIG_SYS_EEPROM_PAGE_WRITE_BITS=5
>> +# CONFIG_CMD_BIND is not set
>>  CONFIG_CMD_CLK=y
>>  CONFIG_CMD_GPIO=y
>> +CONFIG_CMD_I2C=y
>>  CONFIG_CMD_MMC=y
>>  CONFIG_CMD_UFS=y
>>  CONFIG_CMD_USB=y
>>  CONFIG_CMD_CAT=y
>>  CONFIG_CMD_BMP=y
>>  CONFIG_CMD_LOG=y
>>  CONFIG_OF_LIVE=y
>>  # CONFIG_NET is not set
>> +CONFIG_DM_WARN=y
>>  # CONFIG_OFNODE_MULTI_TREE is not set
>>  CONFIG_BUTTON_QCOM_PMIC=y
>>  CONFIG_CLK=y
>>  CONFIG_CLK_QCOM_QCS404=y
>>  CONFIG_CLK_QCOM_SDM845=y
>>  CONFIG_MSM_GPIO=y
>>  CONFIG_QCOM_PMIC_GPIO=y
>> +CONFIG_DM_I2C=y
>> +CONFIG_SYS_I2C_QUP=y
>> +CONFIG_I2C_MUX=y
>>  CONFIG_DM_KEYBOARD=y
>>  CONFIG_BUTTON_KEYBOARD=y
>> +CONFIG_IOMMU=y
>> +CONFIG_QCOM_HYP_SMMU=y
>> +CONFIG_MISC=y
>> +CONFIG_NVMEM=y
>> +CONFIG_I2C_EEPROM=y
>>  CONFIG_MMC_HS200_SUPPORT=y
>>  CONFIG_MMC_SDHCI=y
>>  CONFIG_MMC_SDHCI_ADMA=y
>>  CONFIG_MMC_SDHCI_MSM=y
>> +CONFIG_DM_ETH_PHY=y
>>  CONFIG_PHY=y
>> +CONFIG_PHY_QCOM_QUSB2=y
>> +CONFIG_PHY_QCOM_USB_HS_7NM=y
>>  CONFIG_PINCTRL=y
>>  CONFIG_PINCTRL_QCOM_QCS404=y
>>  CONFIG_PINCTRL_QCOM_SDM845=y
>>  CONFIG_DM_PMIC=y
>>  CONFIG_PMIC_QCOM=y
>> +CONFIG_DM_REGULATOR=y
>> +CONFIG_DM_REGULATOR_FIXED=y
>>  CONFIG_SCSI=y
>>  CONFIG_MSM_SERIAL=y
>>  CONFIG_MSM_GENI_SERIAL=y
>>  CONFIG_SPMI_MSM=y
>> @@ -56,8 +77,13 @@ CONFIG_SYSINFO_SMBIOS=y
>>  CONFIG_USB=y
>>  CONFIG_USB_XHCI_HCD=y
>>  CONFIG_USB_XHCI_DWC3=y
>>  CONFIG_USB_DWC3=y
>> +CONFIG_USB_DWC3_GENERIC=y
>> +CONFIG_USB_GADGET=y
>> +CONFIG_USB_GADGET_DOWNLOAD=y
>> +CONFIG_USB_FUNCTION_MASS_STORAGE=y
>> +CONFIG_USB_FUNCTION_ACM=y
>>  CONFIG_UFS=y
>>  CONFIG_VIDEO=y
>>  # CONFIG_VIDEO_FONT_8X16 is not set
>>  CONFIG_VIDEO_FONT_16X32=y
>> @@ -66,27 +92,4 @@ CONFIG_NO_FB_CLEAR=y
>>  CONFIG_VIDEO_SIMPLE=y
>>  CONFIG_HEXDUMP=y
>>  # CONFIG_GENERATE_SMBIOS_TABLE is not set
>>  CONFIG_LMB_MAX_REGIONS=64
>> -CONFIG_CMD_DHCP=y
>> -CONFIG_CMD_EEPROM=y
>> -CONFIG_CMD_I2C=y
>> -CONFIG_CMD_PING=y
>> -CONFIG_DM_ETH=y
>> -CONFIG_DM_ETH_PHY=y
>> -CONFIG_DM_MDIO=y
>> -CONFIG_DWC_ETH_QOS=y
>> -CONFIG_DWC_ETH_QOS_QCOM=y
> 
> Any particular reason to drop these?

No, this is weird, I must have screwed something up while regenerating
the defconfig. Thanks for catching this, I'll fix it for the next revision.
> 
> -Sumit
> 
>> -CONFIG_RGMII=y
>> -CONFIG_PHY_MICREL=y
>> -CONFIG_PHY_MICREL_KSZ90X1=y
>> -CONFIG_MISC=y
>> -CONFIG_NVMEM=y
>> -CONFIG_DM_I2C=y
>> -CONFIG_I2C_SUPPORT=y
>> -CONFIG_I2C_MUX=y
>> -CONFIG_I2C_EEPROM=y
>> -CONFIG_SYS_I2C=y
>> -CONFIG_SYS_I2C_QUP=y
>> -CONFIG_SYS_I2C_EEPROM_BUS=2
>> -CONFIG_SYS_I2C_EEPROM_ADDR_LEN=2
>> -CONFIG_SYS_EEPROM_PAGE_WRITE_BITS=5
>>
>> --
>> 2.44.0
>>

-- 
// Caleb (they/them)