[PATCH 1/2] usb: udc: dwc3: Fold board dm_usb_gadget_handle_interrupts() into DWC3 gadget

Marek Vasut marek.vasut at mailbox.org
Thu Mar 21 20:38:59 CET 2024


On 3/21/24 11:01 AM, Mattijs Korpershoek wrote:
> Hi Marek,
> 
> Thank you for the patch.
> 
> On dim., mars 17, 2024 at 05:42, Marek Vasut <marek.vasut+renesas at mailbox.org> wrote:
> 
>> The dm_usb_gadget_handle_interrupts() has no place in board code. Move
>> this into DWC3 driver. The OMAP implementation is special, add new weak
>> dwc3_uboot_interrupt_status() function to decide whether DWC3 interrupt
>> handling should be called, and override it in OMAP DWC3 code, to repair
>> the special OMAP interrupt handling code until OMAP gets switched over
>> to DM UDC proper.
>>
>> Signed-off-by: Marek Vasut <marek.vasut+renesas at mailbox.org>
> 
> Reviewed-by: Mattijs Korpershoek <mkorpershoek at baylibre.com>
> 
> Tested that I could scan for usb mass storage and that I can use
> fastboot:
> 
> => fastboot usb 0
> crq->brequest:0x0
> => usb start
> starting USB...
> Bus usb at ff500000: Register 3000140 NbrPorts 3
> Starting the controller
> USB XHCI 1.10
> scanning bus usb at ff500000 for devices... 3 USB Device(s) found
>         scanning usb for storage devices... 1 Storage Device(s) found
> 
> => usb storage
>    Device 0: Vendor: SanDisk Rev: 1.00 Prod: Ultra
>              Type: Removable Hard Disk
>              Capacity: 29328.0 MB = 28.6 GB (60063744 x 512)
> 
> Tested-by: Mattijs Korpershoek <mkorpershoek at baylibre.com> # vim3

Thank you!

Please feel free to pick this via DFU tree in a week or two, so others 
can comment on this and test this too.


More information about the U-Boot mailing list