[PATCH] lib: fix newline in debug message

Heinrich Schuchardt xypron.glpk at gmx.de
Sat Mar 30 02:57:51 CET 2024


Thank you for catching this.

%s/fix/add missing/ would make the subject clearer.

We prefer to have a commit message in all patches, e.g.

    Add missing line break to improve readability.

On 3/29/24 15:22, Maxim Moskalets wrote:
> Signed-off-by: Maxim Moskalets <maximmosk4 at gmail.com>
> ---
>   lib/rsa/rsa-verify.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/rsa/rsa-verify.c b/lib/rsa/rsa-verify.c
> index 1007b6979a..e1093ce1a4 100644
> --- a/lib/rsa/rsa-verify.c
> +++ b/lib/rsa/rsa-verify.c
> @@ -342,7 +342,7 @@ static int rsa_verify_key(struct image_sign_info *info,
>   		return -EINVAL;
>   	}
>
> -	debug("Checksum algorithm: %s", checksum->name);
> +	debug("Checksum algorithm: %s\n", checksum->name);
>
>   	/* Sanity check for stack size */
>   	if (sig_len > RSA_MAX_SIG_BITS / 8) {

Reviewed-by: Heinrich Schuchardt <xypron.glpk at gmx.de>


More information about the U-Boot mailing list