[PATCH] mmc: sdhci: Correct ADMA_DESC_LEN to 12

Greg Malysa greg.malysa at timesys.com
Thu May 2 04:38:38 CEST 2024


Thanks for fixing this for me.

> Confusion probably originates from Linux commit 685e444bbaa0
> ("mmc: sdhci: Add ADMA2 64-bit addressing support for V4 mode"), but
> the latter "V4 mode" was never ported to U-Boot.

I have one of the rare platforms that does not support 64-bit ADMA2 V3
so we also submitted 5359cd1135 ("mmc: Support 32-bit only ADMA on
64-bit platforms") to support that, but if we saw hardware that
required v4 descriptors or someone insisted on it, we'd need to add
another Kconfig for it. Do you think we should port the rest of the v4
support? What about mirroring the kernel's dynamic behavior by
checking the combination of capabilities and control registers to
figure out which mode to use rather than hardcoding it?


--
Greg Malysa
Timesys Corporation


More information about the U-Boot mailing list