[PATCH 28/81] fastboot: Remove <common.h> and add needed includes

Mattijs Korpershoek mkorpershoek at baylibre.com
Thu May 2 09:29:14 CEST 2024


Hi Tom,

Thank you for the patch.

On mer., mai 01, 2024 at 19:30, Tom Rini <trini at konsulko.com> wrote:

> Remove <common.h> from this driver directory and when needed
> add missing include files directly.
>
> Signed-off-by: Tom Rini <trini at konsulko.com>

Reviewed-by: Mattijs Korpershoek <mkorpershoek at baylibre.com>

> ---
> Cc: Mattijs Korpershoek <mkorpershoek at baylibre.com>
> Cc: Tom Rini <trini at konsulko.com>
> ---
>  drivers/fastboot/fb_command.c | 2 +-
>  drivers/fastboot/fb_common.c  | 2 +-
>  drivers/fastboot/fb_getvar.c  | 2 +-
>  drivers/fastboot/fb_mmc.c     | 1 -
>  drivers/fastboot/fb_nand.c    | 1 -
>  5 files changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/fastboot/fb_command.c b/drivers/fastboot/fb_command.c
> index 01443c5d39e2..e4484d65aca5 100644
> --- a/drivers/fastboot/fb_command.c
> +++ b/drivers/fastboot/fb_command.c
> @@ -3,7 +3,6 @@
>   * Copyright (C) 2016 The Android Open Source Project
>   */
>  
> -#include <common.h>
>  #include <command.h>
>  #include <console.h>
>  #include <env.h>
> @@ -13,6 +12,7 @@
>  #include <fb_nand.h>
>  #include <part.h>
>  #include <stdlib.h>
> +#include <vsprintf.h>
>  #include <linux/printk.h>
>  
>  /**
> diff --git a/drivers/fastboot/fb_common.c b/drivers/fastboot/fb_common.c
> index 3576b0677299..12ffb463deb9 100644
> --- a/drivers/fastboot/fb_common.c
> +++ b/drivers/fastboot/fb_common.c
> @@ -11,11 +11,11 @@
>   */
>  
>  #include <bcb.h>
> -#include <common.h>
>  #include <command.h>
>  #include <env.h>
>  #include <fastboot.h>
>  #include <net.h>
> +#include <vsprintf.h>
>  
>  /**
>   * fastboot_buf_addr - base address of the fastboot download buffer
> diff --git a/drivers/fastboot/fb_getvar.c b/drivers/fastboot/fb_getvar.c
> index f65519c57b47..93cbd598e024 100644
> --- a/drivers/fastboot/fb_getvar.c
> +++ b/drivers/fastboot/fb_getvar.c
> @@ -3,7 +3,6 @@
>   * Copyright (C) 2016 The Android Open Source Project
>   */
>  
> -#include <common.h>
>  #include <env.h>
>  #include <fastboot.h>
>  #include <fastboot-internal.h>
> @@ -12,6 +11,7 @@
>  #include <fs.h>
>  #include <part.h>
>  #include <version.h>
> +#include <vsprintf.h>
>  #include <linux/printk.h>
>  
>  static void getvar_version(char *var_parameter, char *response);
> diff --git a/drivers/fastboot/fb_mmc.c b/drivers/fastboot/fb_mmc.c
> index 060918e49109..f11eb66761b1 100644
> --- a/drivers/fastboot/fb_mmc.c
> +++ b/drivers/fastboot/fb_mmc.c
> @@ -4,7 +4,6 @@
>   */
>  
>  #include <config.h>
> -#include <common.h>
>  #include <blk.h>
>  #include <env.h>
>  #include <fastboot.h>
> diff --git a/drivers/fastboot/fb_nand.c b/drivers/fastboot/fb_nand.c
> index bbe26ddcc9be..afc64fd52807 100644
> --- a/drivers/fastboot/fb_nand.c
> +++ b/drivers/fastboot/fb_nand.c
> @@ -5,7 +5,6 @@
>   */
>  
>  #include <config.h>
> -#include <common.h>
>  #include <blk.h>
>  
>  #include <fastboot.h>
> -- 
> 2.34.1


More information about the U-Boot mailing list