[PATCH V2] board: rockchip: Add Indiedroid Nova

[Quentin Schulz]

Hi Chris,

On 5/2/24 8:57 PM, Chris Morgan wrote:
> From: Chris Morgan <macromorgan at hotmail.com>
> 
> The Indiedroid Nova is a Rockchip RK3588S based SBC from Indiedroid.
> 
> Specifications:
> 
>      Rockchip RK3588S SoC
>      4x ARM Cortex-A76, 4x ARM Cortex-A55
>      4/8/16GB memory LPDDR4x
>      Mali G610MC4 GPU
>      Optional eMMC
>      2x USB 2.0, 2x USB 3.0, 1x USB 3.0 C port with DP Alt
>      1x MIPI-CSI Port (4-lane or 2x 2-lane)
>      1x MIPI-DSI 4-lane connector
>      1x Micro HDMI 2.1 output, 1x DP 1.4 output
>      Gigabit Ethernet
>      Realtek RTL8821CS WiFi
>      4 pin debug UART connector
>      40 pin GPIO header
>      Size: 85mm x 56mm (Raspberry Pi Form Factor)
> 
> Kernel commit:
> 3900160e164b ("arm64: dts: rockchip: Add Indiedroid Nova board")
> 
> Signed-off-by: Chris Morgan <macromorgan at hotmail.com>
> ---
> 
> Changes since V1:
>   - Refactored to use the upstream Linux device tree now that that is
>     an option.

Lucky you, I still have to wait for a bump of the upstream dts repo 
"copy" to be able to use this for Tiger (will be in v6.9, so not too 
long to wait for anymore :) ).

>   - Added board to doc/board/rockchip/rockchip.rst.
> 
> ---
>   arch/arm/mach-rockchip/rk3588/Kconfig | 10 ++++
>   board/indiedroid/nova/Kconfig         | 12 +++++
>   board/indiedroid/nova/MAINTAINERS     |  6 +++
>   configs/nova-rk3588s_defconfig        | 70 +++++++++++++++++++++++++++
>   doc/board/rockchip/rockchip.rst       |  1 +
>   include/configs/nova-rk3588s.h        | 15 ++++++
>   6 files changed, 114 insertions(+)
>   create mode 100644 board/indiedroid/nova/Kconfig
>   create mode 100644 board/indiedroid/nova/MAINTAINERS
>   create mode 100644 configs/nova-rk3588s_defconfig
>   create mode 100644 include/configs/nova-rk3588s.h
> 
> diff --git a/arch/arm/mach-rockchip/rk3588/Kconfig b/arch/arm/mach-rockchip/rk3588/Kconfig
> index 39049ab35a..820e979abb 100644
> --- a/arch/arm/mach-rockchip/rk3588/Kconfig
> +++ b/arch/arm/mach-rockchip/rk3588/Kconfig
> @@ -78,6 +78,15 @@ config TARGET_NANOPCT6_RK3588
>   	  Power: 5.5*2.1mm DC Jack, 12VDC input
>   	  Dimensions: 110x80x1.6mm (without case) / 86x114.5x30mm (with case)
>   
> +config TARGET_NOVA_RK3588
> +	bool "Indiedroid Nova RK3588"
> +	select BOARD_LATE_INIT
> +	help
> +	  Indiedroid Nova is a Rockchip RK3588s based SBC by Indiedroid.
> +	  It comes in configurations from 4GB of RAM to 16GB of RAM,
> +	  includes socket for eMMC storage, an SDMMC slot, and a 40-pin
> +	  GPIO header for expansion.
> +
>   config TARGET_RK3588_NEU6
>   	bool "Edgeble Neural Compute Module 6(Neu6) SoM"
>   	select BOARD_LATE_INIT
> @@ -223,6 +232,7 @@ config TEXT_BASE
>   
>   source "board/edgeble/neural-compute-module-6/Kconfig"
>   source "board/friendlyelec/nanopc-t6-rk3588/Kconfig"
> +source "board/indiedroid/nova/Kconfig"
>   source "board/pine64/quartzpro64-rk3588/Kconfig"
>   source "board/turing/turing-rk1-rk3588/Kconfig"
>   source "board/radxa/rock5a-rk3588s/Kconfig"
> diff --git a/board/indiedroid/nova/Kconfig b/board/indiedroid/nova/Kconfig
> new file mode 100644
> index 0000000000..271d15a0ed
> --- /dev/null
> +++ b/board/indiedroid/nova/Kconfig
> @@ -0,0 +1,12 @@
> +if TARGET_NOVA_RK3588
> +
> +config SYS_BOARD
> +	default "nova-rk3588s"
> +
> +config SYS_VENDOR
> +	default "indiedroid"
> +
> +config SYS_CONFIG_NAME
> +	default "nova-rk3588s"
> +
> +endif
> diff --git a/board/indiedroid/nova/MAINTAINERS b/board/indiedroid/nova/MAINTAINERS
> new file mode 100644
> index 0000000000..9c56d01bf0
> --- /dev/null
> +++ b/board/indiedroid/nova/MAINTAINERS
> @@ -0,0 +1,6 @@
> +INDIEDROID-NOVA-RK3588
> +M:	Chris Morgan <macromorgan at hotmail.com>
> +S:	Maintained
> +F:	board/indiedroid/nova
> +F:	include/configs/nova-rk3588s.h
> +F:	configs/indiedroid-nova-rk3588_defconfig

Typo here, missing an s after rk3588 :)

Looking good to me otherwise.

Cheers,
Quentin