[PATCH v2 0/2] qcom: ehci: enable core + iface clocks

Sam Day me at samcday.com
Mon May 6 12:26:51 CEST 2024


These clocks are mandatory, as can be seen in msm_hsusb driver in the
Linux kernel.

The appropriate HS_USB AHB/SYSTEM clocks were added to gcc_apq8016.

Technically there's other adjacent SoC families that can use the
msm_hsusb driver with different clocks, but only msm8916/apq8016 are
currently making use of it so I think this change shouldn't break
anything elsewhere.

Signed-off-by: Sam Day <me at samcday.com>
---
Changes in v2:
- Remove nonsensical/unnecessary reference to pending qcom debug dump
  from commit message.
- Collapse ftbl_gcc_usb_hs_system_clk into apq8016_clk_set_rate, since
  it's only 1 entry.
- Add bounds check on clock id in apq8016_clk_enable
- Add warn if a rate other than 80mhz is requested for
  GCC_USB_HS_SYSTEM_CLK
- Caleb: I opted to keep the non-bulk clock enablement code as-is in
  ehci_msm, since that more closely resembles the existing Linux
  kernel code.
- Link to v1: https://lore.kernel.org/r/20240502-msm8916-hs-usb-clocks-v1-0-eeccf483b68d@samcday.com

---
Sam Day (2):
      clk/qcom: apq8016: add support for USB_HS clocks
      ehci: msm: bring up iface + core clocks

 drivers/clk/qcom/clock-apq8016.c | 32 ++++++++++++++++++++++++++++++++
 drivers/usb/host/ehci-msm.c      | 37 +++++++++++++++++++++++++++++++++++--
 2 files changed, 67 insertions(+), 2 deletions(-)
---
base-commit: 2f1e76bcfee75b9f99ade63002c05ffaaec86afb
change-id: 20240502-msm8916-hs-usb-clocks-34bc22b03f3d

Best regards,
-- 
Sam Day <me at samcday.com>




More information about the U-Boot mailing list