[PATCH 29/81] firmware: Remove <common.h> and add needed includes

Ilias Apalodimas ilias.apalodimas at linaro.org
Tue May 7 09:37:28 CEST 2024


On Thu, 2 May 2024 at 04:32, Tom Rini <trini at konsulko.com> wrote:
>
> Remove <common.h> from this driver directory and when needed
> add missing include files directly.
>
> Signed-off-by: Tom Rini <trini at konsulko.com>
> ---
> Cc: Abdellatif El Khlifi <abdellatif.elkhlifi at arm.com>
> Cc: Tom Rini <trini at konsulko.com>
> Cc: Simon Glass <sjg at chromium.org>
> Cc: Michal Simek <michal.simek at amd.com>
> Cc: Jens Wiklander <jens.wiklander at linaro.org>
> Cc: Ilias Apalodimas <ilias.apalodimas at linaro.org>
> Cc: Stefan Herbrechtsmeier <stefan.herbrechtsmeier at weidmueller.com>
> Cc: Venkatesh Yadav Abbarapu <venkatesh.abbarapu at amd.com>
> Cc: Tanmay Shah <tanmay.shah at amd.com>
> Cc: Ashok Reddy Soma <ashok.reddy.soma at amd.com>
> Cc: Weizhao Ouyang <o451686892 at gmail.com>
> Cc: AKASHI Takahiro <akashi.tkhro at gmail.com>
> Cc: Etienne Carriere <etienne.carriere at foss.st.com>
> ---
>  drivers/firmware/arm-ffa/arm-ffa-uclass.c    | 1 -
>  drivers/firmware/arm-ffa/arm-ffa.c           | 1 -
>  drivers/firmware/arm-ffa/ffa-emul-uclass.c   | 1 -
>  drivers/firmware/arm-ffa/sandbox_ffa.c       | 1 -
>  drivers/firmware/firmware-sandbox.c          | 1 -
>  drivers/firmware/firmware-uclass.c           | 1 -
>  drivers/firmware/firmware-zynqmp.c           | 1 -
>  drivers/firmware/psci.c                      | 1 -
>  drivers/firmware/scmi/base.c                 | 1 -
>  drivers/firmware/scmi/mailbox_agent.c        | 1 -
>  drivers/firmware/scmi/optee_agent.c          | 1 -
>  drivers/firmware/scmi/sandbox-scmi_agent.c   | 1 -
>  drivers/firmware/scmi/sandbox-scmi_devices.c | 1 -
>  drivers/firmware/scmi/scmi_agent-uclass.c    | 1 -
>  drivers/firmware/scmi/smccc_agent.c          | 1 -
>  drivers/firmware/scmi/smt.c                  | 1 -
>  drivers/firmware/ti_sci.c                    | 1 -
>  17 files changed, 17 deletions(-)
>
> diff --git a/drivers/firmware/arm-ffa/arm-ffa-uclass.c b/drivers/firmware/arm-ffa/arm-ffa-uclass.c
> index f1e91d151ea3..e0767fc75517 100644
> --- a/drivers/firmware/arm-ffa/arm-ffa-uclass.c
> +++ b/drivers/firmware/arm-ffa/arm-ffa-uclass.c
> @@ -5,7 +5,6 @@
>   * Authors:
>   *   Abdellatif El Khlifi <abdellatif.elkhlifi at arm.com>
>   */
> -#include <common.h>
>  #include <arm_ffa.h>
>  #include <arm_ffa_priv.h>
>  #include <dm.h>
> diff --git a/drivers/firmware/arm-ffa/arm-ffa.c b/drivers/firmware/arm-ffa/arm-ffa.c
> index ee0bf9a55b48..94e6105cb38e 100644
> --- a/drivers/firmware/arm-ffa/arm-ffa.c
> +++ b/drivers/firmware/arm-ffa/arm-ffa.c
> @@ -6,7 +6,6 @@
>   *   Abdellatif El Khlifi <abdellatif.elkhlifi at arm.com>
>   */
>
> -#include <common.h>
>  #include <arm_ffa.h>
>  #include <arm_ffa_priv.h>
>  #include <dm.h>
> diff --git a/drivers/firmware/arm-ffa/ffa-emul-uclass.c b/drivers/firmware/arm-ffa/ffa-emul-uclass.c
> index 4bf9f6041fec..1521d9b66ac3 100644
> --- a/drivers/firmware/arm-ffa/ffa-emul-uclass.c
> +++ b/drivers/firmware/arm-ffa/ffa-emul-uclass.c
> @@ -5,7 +5,6 @@
>   * Authors:
>   *   Abdellatif El Khlifi <abdellatif.elkhlifi at arm.com>
>   */
> -#include <common.h>
>  #include <dm.h>
>  #include <mapmem.h>
>  #include <string.h>
> diff --git a/drivers/firmware/arm-ffa/sandbox_ffa.c b/drivers/firmware/arm-ffa/sandbox_ffa.c
> index 11142429c09b..44b32a829ddf 100644
> --- a/drivers/firmware/arm-ffa/sandbox_ffa.c
> +++ b/drivers/firmware/arm-ffa/sandbox_ffa.c
> @@ -5,7 +5,6 @@
>   * Authors:
>   *   Abdellatif El Khlifi <abdellatif.elkhlifi at arm.com>
>   */
> -#include <common.h>
>  #include <arm_ffa.h>
>  #include <dm.h>
>  #include <log.h>
> diff --git a/drivers/firmware/firmware-sandbox.c b/drivers/firmware/firmware-sandbox.c
> index d970d75f781d..226b5cfc191e 100644
> --- a/drivers/firmware/firmware-sandbox.c
> +++ b/drivers/firmware/firmware-sandbox.c
> @@ -5,7 +5,6 @@
>   * Copyright (C) 2018 Xilinx, Inc.
>   */
>
> -#include <common.h>
>  #include <dm.h>
>
>  static const struct udevice_id generic_sandbox_firmware_ids[] = {
> diff --git a/drivers/firmware/firmware-uclass.c b/drivers/firmware/firmware-uclass.c
> index e83a147a000b..84caf25548be 100644
> --- a/drivers/firmware/firmware-uclass.c
> +++ b/drivers/firmware/firmware-uclass.c
> @@ -2,7 +2,6 @@
>
>  #define LOG_CATEGORY UCLASS_FIRMWARE
>
> -#include <common.h>
>  #include <dm.h>
>
>  /* Firmware access is platform-dependent.  No generic code in uclass */
> diff --git a/drivers/firmware/firmware-zynqmp.c b/drivers/firmware/firmware-zynqmp.c
> index dfad798a2e7d..f99507d86c61 100644
> --- a/drivers/firmware/firmware-zynqmp.c
> +++ b/drivers/firmware/firmware-zynqmp.c
> @@ -5,7 +5,6 @@
>   * Copyright (C) 2018-2019 Xilinx, Inc.
>   */
>
> -#include <common.h>
>  #include <cpu_func.h>
>  #include <dm.h>
>  #include <dm/device_compat.h>
> diff --git a/drivers/firmware/psci.c b/drivers/firmware/psci.c
> index 03544d76ed4a..c32c3f5c6a54 100644
> --- a/drivers/firmware/psci.c
> +++ b/drivers/firmware/psci.c
> @@ -6,7 +6,6 @@
>   * Copyright (C) 2015 ARM Limited
>   */
>
> -#include <common.h>
>  #include <command.h>
>  #include <dm.h>
>  #include <efi_loader.h>
> diff --git a/drivers/firmware/scmi/base.c b/drivers/firmware/scmi/base.c
> index 1d41a8a98fc6..f4e3974ff5b4 100644
> --- a/drivers/firmware/scmi/base.c
> +++ b/drivers/firmware/scmi/base.c
> @@ -6,7 +6,6 @@
>   *             author: AKASHI Takahiro <takahiro.akashi at linaro.org>
>   */
>
> -#include <common.h>
>  #include <dm.h>
>  #include <scmi_agent.h>
>  #include <scmi_protocols.h>
> diff --git a/drivers/firmware/scmi/mailbox_agent.c b/drivers/firmware/scmi/mailbox_agent.c
> index 7ad3e8da9f08..6d4497f4b92a 100644
> --- a/drivers/firmware/scmi/mailbox_agent.c
> +++ b/drivers/firmware/scmi/mailbox_agent.c
> @@ -5,7 +5,6 @@
>
>  #define LOG_CATEGORY UCLASS_SCMI_AGENT
>
> -#include <common.h>
>  #include <dm.h>
>  #include <errno.h>
>  #include <mailbox.h>
> diff --git a/drivers/firmware/scmi/optee_agent.c b/drivers/firmware/scmi/optee_agent.c
> index 48dbb88a3fb5..631625d715bf 100644
> --- a/drivers/firmware/scmi/optee_agent.c
> +++ b/drivers/firmware/scmi/optee_agent.c
> @@ -5,7 +5,6 @@
>
>  #define LOG_CATEGORY UCLASS_SCMI_AGENT
>
> -#include <common.h>
>  #include <dm.h>
>  #include <errno.h>
>  #include <scmi_agent.h>
> diff --git a/drivers/firmware/scmi/sandbox-scmi_agent.c b/drivers/firmware/scmi/sandbox-scmi_agent.c
> index cc9011c7312f..19be280ec448 100644
> --- a/drivers/firmware/scmi/sandbox-scmi_agent.c
> +++ b/drivers/firmware/scmi/sandbox-scmi_agent.c
> @@ -5,7 +5,6 @@
>
>  #define LOG_CATEGORY UCLASS_SCMI_AGENT
>
> -#include <common.h>
>  #include <dm.h>
>  #include <malloc.h>
>  #include <scmi_agent.h>
> diff --git a/drivers/firmware/scmi/sandbox-scmi_devices.c b/drivers/firmware/scmi/sandbox-scmi_devices.c
> index 603e2bb40aff..96c2922b067e 100644
> --- a/drivers/firmware/scmi/sandbox-scmi_devices.c
> +++ b/drivers/firmware/scmi/sandbox-scmi_devices.c
> @@ -5,7 +5,6 @@
>
>  #define LOG_CATEGORY UCLASS_MISC
>
> -#include <common.h>
>  #include <clk.h>
>  #include <dm.h>
>  #include <log.h>
> diff --git a/drivers/firmware/scmi/scmi_agent-uclass.c b/drivers/firmware/scmi/scmi_agent-uclass.c
> index 0f1003e167e6..8c907c3b0328 100644
> --- a/drivers/firmware/scmi/scmi_agent-uclass.c
> +++ b/drivers/firmware/scmi/scmi_agent-uclass.c
> @@ -5,7 +5,6 @@
>
>  #define LOG_CATEGORY UCLASS_SCMI_AGENT
>
> -#include <common.h>
>  #include <dm.h>
>  #include <errno.h>
>  #include <scmi_agent.h>
> diff --git a/drivers/firmware/scmi/smccc_agent.c b/drivers/firmware/scmi/smccc_agent.c
> index 972c6addde21..ac35d07ebaff 100644
> --- a/drivers/firmware/scmi/smccc_agent.c
> +++ b/drivers/firmware/scmi/smccc_agent.c
> @@ -5,7 +5,6 @@
>
>  #define LOG_CATEGORY UCLASS_SCMI_AGENT
>
> -#include <common.h>
>  #include <dm.h>
>  #include <errno.h>
>  #include <scmi_agent.h>
> diff --git a/drivers/firmware/scmi/smt.c b/drivers/firmware/scmi/smt.c
> index 509ed618a997..67d2f4500249 100644
> --- a/drivers/firmware/scmi/smt.c
> +++ b/drivers/firmware/scmi/smt.c
> @@ -6,7 +6,6 @@
>
>  #define LOG_CATEGORY UCLASS_SCMI_AGENT
>
> -#include <common.h>
>  #include <cpu_func.h>
>  #include <dm.h>
>  #include <dm/device_compat.h>
> diff --git a/drivers/firmware/ti_sci.c b/drivers/firmware/ti_sci.c
> index 6c581b9df9c0..8ce0f46e70c8 100644
> --- a/drivers/firmware/ti_sci.c
> +++ b/drivers/firmware/ti_sci.c
> @@ -7,7 +7,6 @@
>   *     Lokesh Vutla <lokeshvutla at ti.com>
>   */
>
> -#include <common.h>
>  #include <dm.h>
>  #include <errno.h>
>  #include <log.h>
> --
> 2.34.1
>

Reviewed-by: Ilias Apalodimas <ilias.apalodimas at linaro.org>


More information about the U-Boot mailing list