[PATCH v2 05/28] image: remove redundant hash includes

Ilias Apalodimas ilias.apalodimas at linaro.org
Wed May 8 12:13:25 CEST 2024


On Tue, 7 May 2024 at 20:54, Raymond Mao <raymond.mao at linaro.org> wrote:
>
> Remove the redundant includes of u-boot/md5.h, u-boot/sha1.h,
> u-boot/sha256.h and u-boot/sha512.h
>
> Signed-off-by: Raymond Mao <raymond.mao at linaro.org>
> ---
> Changes in v2
> - None.
>
>  boot/image-fit.c | 4 ----
>  boot/image.c     | 2 --
>  2 files changed, 6 deletions(-)
>
> diff --git a/boot/image-fit.c b/boot/image-fit.c
> index 89e377563ce..1efc39f4408 100644
> --- a/boot/image-fit.c
> +++ b/boot/image-fit.c
> @@ -38,10 +38,6 @@ DECLARE_GLOBAL_DATA_PTR;
>  #include <image.h>
>  #include <bootstage.h>
>  #include <u-boot/crc.h>
> -#include <u-boot/md5.h>
> -#include <u-boot/sha1.h>
> -#include <u-boot/sha256.h>
> -#include <u-boot/sha512.h>
>
>  /*****************************************************************************/
>  /* New uImage format routines */
> diff --git a/boot/image.c b/boot/image.c
> index 073931cd7a3..e57d6eae52d 100644
> --- a/boot/image.c
> +++ b/boot/image.c
> @@ -26,8 +26,6 @@
>  #endif
>
>  #include <asm/global_data.h>
> -#include <u-boot/md5.h>
> -#include <u-boot/sha1.h>
>  #include <linux/errno.h>
>  #include <asm/io.h>
>
> --
> 2.25.1
>

This seems unrelated to the series of mbedTLS. Can you send a series
with the fixes independently? Tom can pick them up before mbedTLS and
it would make the review process easier


Reviewed-by: Ilias Apalodimas <ilias.apalodimas at linaro.org>


More information about the U-Boot mailing list