[PATCH 1/1] riscv: simplify backtrace report

Leo Liang ycliang at andestech.com
Tue May 14 11:54:01 CEST 2024


On Tue, May 14, 2024 at 07:51:42AM +0200, Heinrich Schuchardt wrote:
> * We already have a header 'backtrace', there is no need to repeat the
>   word backtrace on every line.
> * Add a blank line before the backtrace section of the crash report for
>   improved readability.
> * If U-Boot is compiled without backtrace, there is no need to write a
>   message at all.
> * Avoid #ifdef. We prefer functions to always be compiled and let
>   the linker remove them if not needed.
> * Foresee 3 digits for the backtrace index.
> 
> For testing the 'exception' command can be used.
> 
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt at canonical.com>
> ---
>  arch/riscv/lib/interrupts.c | 16 +++++-----------
>  1 file changed, 5 insertions(+), 11 deletions(-)

Reviewed-by: Leo Yu-Chi Liang <ycliang at andestech.com>


More information about the U-Boot mailing list