[PATCH] fdt: add kaslr-seed if DM_RNG is enabled

Marek Vasut marex at denx.de
Wed May 15 22:05:28 CEST 2024


On 5/15/24 9:57 PM, Tim Harvey wrote:

[...]

>> The kaslrseed command similarly becomes obsolete with your patch and
>> should be removed. 'git grep -n CMD_KASLR' indicates which defconfigs
>> would be impacted.
>>
> 
> There are several users of this command currently:
> $ git grep CMD_KASLR configs/
> configs/evb-rk3308_defconfig:CONFIG_CMD_KASLRSEED=y

These four i.MX8M I can test (and you can drop the kaslrseed command 
from them, no worries).

> configs/imx8mm_data_modul_edm_sbc_defconfig:CONFIG_CMD_KASLRSEED=y
> configs/imx8mp_data_modul_edm_sbc_defconfig:CONFIG_CMD_KASLRSEED=y
> configs/imx8mp_dhcom_pdk2_defconfig:CONFIG_CMD_KASLRSEED=y
> configs/imx8mp_dhcom_pdk3_defconfig:CONFIG_CMD_KASLRSEED=y
> configs/roc-cc-rk3308_defconfig:CONFIG_CMD_KASLRSEED=y
> configs/rock-pi-s-rk3308_defconfig:CONFIG_CMD_KASLRSEED=y
> configs/xilinx_versal_net_virt_defconfig:CONFIG_CMD_KASLRSEED=y
> configs/xilinx_versal_virt_defconfig:CONFIG_CMD_KASLRSEED=y
> configs/xilinx_zynqmp_kria_defconfig:CONFIG_CMD_KASLRSEED=y
> configs/xilinx_zynqmp_virt_defconfig:CONFIG_CMD_KASLRSEED=y
> 
> While I can deduplicate code by calling a shared function in that
> command I don't feel like I should remove that command until the
> maintainers of the boards above agree on removing it from their
> defconfigs as they could have bootscripts that fail with the command
> missing.
> 
> I could add a warning print in the kaslrseed command indicating that
> the use of this command is no longer needed.

That sounds good to me.


More information about the U-Boot mailing list