[PATCH v2] fdt: automatically add /chosen/kaslr-seed if DM_RNG is enabled

[Marek Vasut]

On 5/15/24 11:11 PM, Tim Harvey wrote:
> On Wed, May 15, 2024 at 2:06 PM Marek Vasut <marex at denx.de> wrote:
>>
>> On 5/15/24 10:50 PM, Tim Harvey wrote:
>>
>> [...]
>>
>>> diff --git a/boot/fdt_support.c b/boot/fdt_support.c
>>> index 874ca4d6f5af..3455d60d69dc 100644
>>> --- a/boot/fdt_support.c
>>> +++ b/boot/fdt_support.c
>>> @@ -8,6 +8,7 @@
>>>
>>>    #include <abuf.h>
>>>    #include <env.h>
>>> +#include <kaslrseed.h>
>>>    #include <log.h>
>>>    #include <mapmem.h>
>>>    #include <net.h>
>>> @@ -300,6 +301,15 @@ int fdt_chosen(void *fdt)
>>>        if (nodeoffset < 0)
>>>                return nodeoffset;
>>>
>>> +     if (IS_ENABLED(CONFIG_DM_RNG) && !IS_ENABLED(ARMV8_SEC_FIRMWARE_SUPPORT)) {
>>> +             err = fdt_kaslrseed(fdt);
>>> +             if (err) {
>>> +                     printf("WARNING: could not set kaslr-seed %s.\n",
>>> +                            fdt_strerror(err));
>>> +                     return err;
>>
>> Is this warning really a critical boot-breaking error ?
> 
> no, and in fact I'm printing a warning inside of fdt_kaslrseed so I
> can remove the duplication of error prints in the various other places
> it's called as well.
> 
> Thanks for pointing that out!

Glad I could help.