[PATCH 1/1] Makefile: add build-sandbox*/ to mrproper target

[Heinrich Schuchardt]

On 5/17/24 17:18, Tom Rini wrote:
> On Fri, May 17, 2024 at 05:15:34PM +0200, Heinrich Schuchardt wrote:
> 
>> make mrproper should remove all build artefacts.
>>
>> Running make tests without deleting build-sandbox led to an error
>>
>>      *** No rule to make target '../include/common.h',
>>      needed by 'include/config/auto.conf'.
>>
>> on my machine.
>>
>> Let's add the build-sandbox*/ directories to the mrproper target.
>>
>> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt at canonical.com>
>> ---
>>   Makefile | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> I don't believe it's the right place to remove build directories. This
> is also incomplete as it wouldn't clean up other platforms that can be
> built, and of course it cannot handle out of tree build directories. All
> build directories regardless of where they are need to be removed as
> that particular change breaks re-using build directories before/after
> it.
> 

My expectation is that after 'make mrproper; git clean -df' I have no 
build artifacts left over.

In .gitignore I find '/build*'. This results in 'git clean -df' not 
removing the the build directories either.

Tom, what is your suggestion?

Best regards

Heinrich