[PATCH 1/2 v5] board: starfive: support Pine64 Star64 board

[H Bell]

On Wednesday, May 22nd, 2024 at 9:40 PM, E Shattow <lucent at gmail.com> wrote:

> On Wed, May 22, 2024 at 12:13?PM H Bell dmoo_dv at protonmail.com wrote:
> 
> > + {"/soc/ethernet at 16040000/mdio/ethernet-phy at 1",
> > + "tx-internal-delay-ps", "300"},
> 
> 
> Note this 300uS value for tx-internal-delay-ps differs from
> pre-loaded firmware on Star64:
> ethernet-phy at 1 tx_delay_sel = <0x00>;
> 
> 
> I would prefer to this (even if it is wrong) same as the pre-loaded
> firmware has done. Tuning patches can be applied in some
> future series. Is there a noticeable difference in function to change
> this value from how the pre-loaded firmware does this?

I agree that it should stick to the pre-loaded firmware wherever possible
but I found that using the 0 value on the tx_delay_sel meant that the device
would not properly send packets over the network (and would not get granted
an IP over DHCP), and found (going in steps of 150) that 300 worked.