[PATCH v2 0/6] Introduce UBI block device

Dario Binacchi dario.binacchi at amarulasolutions.com
Fri May 24 11:01:13 CEST 2024


Hi Alexey,

On Thu, May 23, 2024 at 12:59 PM Alexey Romanov
<avromanov at salutedevices.com> wrote:
>
> On Thu, May 23, 2024 at 12:51:33PM +0200, Michael Nazzareno Trimarchi wrote:
> > Hi
> >
> > We queue them this afternoon
>
> Thank you.
>
> I also wanted to remind you that there is still a similiar patchest with
> mtdblock support (https://lore.kernel.org/all/20240506135607.aprjqn7uyng2jgp5@cab-wsm-0029881/)
> that should be applied to bracnh before this.
>
> >
> > Michael
> >
> > On Thu, May 23, 2024 at 12:49 PM Alexey Romanov
> > <avromanov at salutedevices.com> wrote:
> > >
> > >
> > > Hi Michael,
> > >
> > > On Mon, May 06, 2024 at 03:59:52PM +0200, Michael Nazzareno Trimarchi wrote:
> > > > Hi Alexey
> > > >
> > > > Sorry will will put on CI
> > >
> > > Any news?
> > >
> > > >
> > > > Michael
> > > >
> > > > On Mon, May 6, 2024 at 3:58 PM Alexey Romanov
> > > > <avromanov at salutedevices.com> wrote:
> > > > >
> > > > > Hello! Ping.
> > > > >
> > > > > On Mon, Mar 25, 2024 at 05:41:42PM +0300, Alexey Romanov wrote:
> > > > > > Hello!
> > > > > >
> > > > > > This series adds support for the UBI block device, which
> > > > > > allows to read/write data block by block. For example,
> > > > > > it can now be used for BCB or Android AB command:
> > > > > >
> > > > > >   $ bcb load ubi 0 part_name
> > > > > >
> > > > > > Tested only on SPI NAND, so bind is made only for
> > > > > > SPI NAND drivers. Can be used with mtdblock device [1].
> > > > > >
> > > > > > ---
> > > > > >
> > > > > > Changes V1 -> V2 [2]:
> > > > > >
> > > > > >  - Rebased over mtdblock v2 patchset [3].
> > > > > >  - Compile UBI partitions support only if CONFIG_BLK option
> > > > > >    is enabled.
> > > > > >
> > > > > > - Links:
> > > > > >
> > > > > >   [1] https://lore.kernel.org/all/20240227100441.1811047-1-avromanov@salutedevices.com/
> > > > > >   [2] https://lore.kernel.org/all/20240306134906.1179285-1-avromanov@salutedevices.com/
> > > > > >   [3] https://lore.kernel.org/all/20240307130726.1582487-1-avromanov@salutedevices.com/
> > > > > >
> > > > > > Alexey Romanov (6):
> > > > > >   ubi: allow to read from volume with offset
> > > > > >   ubi: allow to write to volume with offset
> > > > > >   drivers: introduce UBI block abstraction
> > > > > >   disk: don't try search for partition type if already set
> > > > > >   disk: support UBI partitions
> > > > > >   spinand: bind UBI block
> > > > > >
> > > > > >  cmd/ubi.c                   |  77 +++++++++++++++++++--
> > > > > >  disk/part.c                 |   7 ++
> > > > > >  drivers/block/blk-uclass.c  |   1 +
> > > > > >  drivers/mtd/nand/spi/core.c |   8 ++-
> > > > > >  drivers/mtd/ubi/Makefile    |   1 +
> > > > > >  drivers/mtd/ubi/block.c     | 130 ++++++++++++++++++++++++++++++++++++
> > > > > >  drivers/mtd/ubi/part.c      |  99 +++++++++++++++++++++++++++
> > > > > >  env/ubi.c                   |  16 ++---
> > > > > >  include/part.h              |   2 +
> > > > > >  include/ubi_uboot.h         |   8 ++-
> > > > > >  10 files changed, 332 insertions(+), 17 deletions(-)
> > > > > >  create mode 100644 drivers/mtd/ubi/block.c
> > > > > >  create mode 100644 drivers/mtd/ubi/part.c
> > > > > >
> > > > > > --
> > > > > > 2.34.1
> > > > > >
> > > > >
> > > > > --
> > > > > Thank you,
> > > > > Alexey
> > > >
> > > >
> > > >
> > > > --
> > > > Michael Nazzareno Trimarchi
> > > > Co-Founder & Chief Executive Officer
> > > > M. +39 347 913 2170
> > > > michael at amarulasolutions.com
> > > > __________________________________
> > > >
> > > > Amarula Solutions BV
> > > > Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
> > > > T. +31 (0)85 111 9172
> > > > info at amarulasolutions.com
> > > > www.amarulasolutions.com
> > >
> > > --
> > > Thank you,
> > > Alexey
> >
> >
> >
> > --
> > Michael Nazzareno Trimarchi
> > Co-Founder & Chief Executive Officer
> > M. +39 347 913 2170
> > michael at amarulasolutions.com
> > __________________________________
> >
> > Amarula Solutions BV
> > Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
> > T. +31 (0)85 111 9172
> > info at amarulasolutions.com
> > www.amarulasolutions.com
>
> --
> Thank you,
> Alexey

I applied your series

https://patchwork.ozlabs.org/user/todo/uboot/?series=401667
https://patchwork.ozlabs.org/user/todo/uboot/?series=400302

but the CI fails. The first applied series already has problems:

Building current source for 1 boards (1 thread, 64 jobs per thread)
53 x86: + coreboot
54+In file included from include/linux/printk.h:4,
55+ from include/linux/kernel.h:5,
56+ from include/linux/bitops.h:22,
57+ from include/uuid.h:13,
58+ from include/part.h:11,
59+ from drivers/mtd/mtdblock.c:55:
60+drivers/mtd/mtdblock.c: In function 'mtd_blk_read':
61+drivers/mtd/mtdblock.c:100:32: error: format '%lx' expects argument
of type 'long unsigned int', but argument 7 has type 'lbaint_t' {aka
'long long unsigned int'} [-Werror=format=]
62+ 100 | pr_err("mtdblock: failed to read block 0x%lx\n", cur);
63+ | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
64+include/log.h:157:21: note: in definition of macro 'pr_fmt'
65+ 157 | #define pr_fmt(fmt) fmt
66+ | ^~~
67+include/log.h:178:33: note: in expansion of macro 'log'
68+ 178 | #define log_err(_fmt...) log(LOG_CATEGORY, LOGL_ERR, ##_fmt)
69+ | ^~~
70+include/linux/printk.h:50:31: note: in expansion of macro 'log_err'
71+ 50 | CONFIG_LOGLEVEL > 3 ? log_err(fmt, ##__VA_ARGS__) : 0; \
72+ | ^~~~~~~
73+drivers/mtd/mtdblock.c:100:25: note: in expansion of macro 'pr_err'
74+ | ^~~~~~
75+drivers/mtd/mtdblock.c:100:68: note: format string is defined here
76+ | ~~^
77+ | |
78+ | long unsigned int
79+ | %llx
80+drivers/mtd/mtdblock.c: In function 'mtd_blk_write':
81+drivers/mtd/mtdblock.c:167:32: error: format '%lx' expects argument
of type 'long unsigned int', but argument 7 has type 'lbaint_t' {aka
'long long unsigned int'} [-Werror=format=]
82+ 167 | pr_err("mtdblock: failed to read block 0x%lx\n", cur);
83

Please run the tests locally to fix the errors.

Thanks and regards,
Dario

-- 

Dario Binacchi

Senior Embedded Linux Developer

dario.binacchi at amarulasolutions.com

__________________________________


Amarula Solutions SRL

Via Le Canevare 30, 31100 Treviso, Veneto, IT

T. +39 042 243 5310
info at amarulasolutions.com

www.amarulasolutions.com


More information about the U-Boot mailing list